8252173: Use handles instead of jobjects in modules.cpp

[hseigel]

Hi,
Please review this change for JDK-8252173 to use handles instead of jobjects in modules.cpp to make modules.cpp more debuggable. The change was tested with Mach5 tiers 1 and 2 on Linux, Mac OS, and Windows, and tiers 3-5 on Linux x64.

Thanks, Harold

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8252173: Use handles instead of jobjects in modules.cpp

Reviewers

• Lois Foltan (@lfoltan - Reviewer)
• Coleen Phillimore (@coleenp - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2878/head:pull/2878
$ git checkout pull/2878

[bridgekeeper]

👋 Welcome back hseigel! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@hseigel The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (99ba6f9)

[lfoltan]

Looks good Harold!

Lois

[openjdk]

@hseigel This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8252173: Use handles instead of jobjects in modules.cpp

Reviewed-by: lfoltan, coleenp

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

• f71b21b: 8263038: Optimize String.format for simple specifiers
• 14cfbda: 8261366: Add discussion of IEEE 754 to BigDecimal
• 414ee95: 8261462: GCM ByteBuffer decryption problems
• eb4a8af: 8260664: Phaser.arrive() memory consistency effects
• 9221540: 8213269: convert test/hotspot/jtreg/runtime/memory/RunUnitTestsConcurrently to gtest
• 17853ee: 8263200: Add -XX:StressCCP to CTW

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[coleenp]

Looks good!

[hseigel]

Thanks Lois and Coleen for reviewing this!

/integrate

[openjdk]

@hseigel Since your change was applied there have been 16 commits pushed to the master branch:

• a6e34b3: 8262829: Native crash in Win32PrintServiceLookup.getAllPrinterNames()
• fbe40e8: 8252399: Update mapMulti documentation to use type test pattern instead of instanceof once JEP 375 exits preview
• 0f2402d: 8263190: Update java.io, java.math, and java.text to use instanceof pattern variable
• 4f0a12e: 8262323: do not special case JVMCI in tiered compilation policy
• 3022baa: 8263167: IGV: build fails with "taskdef AutoUpdate cannot be found"
• 0bc4562: 8263068: Rename safefetch.hpp to safefetch.inline.hpp
• 5bfc5fd: 8263051: Modernize the code in the java.awt.color package
• 5b9b170: 8262955: Unify os::fork_and_exec() across Posix platforms
• 39b1113: 8262161: Refactor manual I/O stream copying in java.desktop to use new convenience APIs
• 4e94760: 8263135: unique_ptr should not be used for types that are not pointers
• ... and 6 more: https://git.openjdk.java.net/jdk/compare/a2b8858131ebc2a808d6e58decb264b7aff9134d...master

Your commit was automatically rebased without conflicts.

Pushed as commit b7f0b3f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.