8371559: Intermittent timeouts in test javax/net/ssl/Stapling/HttpsUrlConnClient.java#28784
8371559: Intermittent timeouts in test javax/net/ssl/Stapling/HttpsUrlConnClient.java#28784ArnoZeller wants to merge 5 commits intoopenjdk:masterfrom
Conversation
|
👋 Welcome back azeller! A progress list of the required criteria for merging this PR into |
|
@ArnoZeller This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 38 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@myankelev, @MBaesken) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
|
@ArnoZeller The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
|
Actually, what do you think about changing this test to utilise a countdownlatch instead of |
I changed the test accordingly and resolved the wildcard imports. Please have a look. |
|
Thank you for you changes, this looks good to me |
|
@myankelev : Thanks a lot for your suggestions and the review - I will now let this pull request run for two days in our test system to see if our issues are completely solved. |
|
I have seen no issues in our test landscape with this PR. |
|
/integrate |
|
@ArnoZeller |
|
Thanks @myankelev and @MBaesken for the reviews. Would one of you be so nice to sponsor this change? |
|
/sponsor |
|
Going to push as commit af18fbd.
Your commit was automatically rebased without conflicts. |
|
@MBaesken @ArnoZeller Pushed as commit af18fbd. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
|
/backport jdk21u-dev |
|
@xiezhaokun the backport was successfully created on the branch backport-xiezhaokun-af18fbd4-master in my personal fork of openjdk/jdk21u-dev. To create a pull request with this backport targeting openjdk/jdk21u-dev:master, just click the following link: The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:
If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk21u-dev: |
The test javax/net/ssl/Stapling/HttpsUrlConnClient.java sometimes hangs and run into timeouts. By adding some more tracing it showed that it can happen on machines with high load that the client thread throws a "Server not ready yet" RuntimeException because it only waits for 5 seconds for the server thread to come available.
I added some more output in case of errors to better see the issue and use the timeout factor to modify the maximum wait time.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28784/head:pull/28784$ git checkout pull/28784Update a local copy of the PR:
$ git checkout pull/28784$ git pull https://git.openjdk.org/jdk.git pull/28784/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 28784View PR using the GUI difftool:
$ git pr show -t 28784Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28784.diff
Using Webrev
Link to Webrev Comment