Skip to content

8371559: Intermittent timeouts in test javax/net/ssl/Stapling/HttpsUrlConnClient.java#28784

Closed
ArnoZeller wants to merge 5 commits intoopenjdk:masterfrom
ArnoZeller:JDK-8371559
Closed

8371559: Intermittent timeouts in test javax/net/ssl/Stapling/HttpsUrlConnClient.java#28784
ArnoZeller wants to merge 5 commits intoopenjdk:masterfrom
ArnoZeller:JDK-8371559

Conversation

@ArnoZeller
Copy link
Contributor

@ArnoZeller ArnoZeller commented Dec 12, 2025

The test javax/net/ssl/Stapling/HttpsUrlConnClient.java sometimes hangs and run into timeouts. By adding some more tracing it showed that it can happen on machines with high load that the client thread throws a "Server not ready yet" RuntimeException because it only waits for 5 seconds for the server thread to come available.
I added some more output in case of errors to better see the issue and use the timeout factor to modify the maximum wait time.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8371559: Intermittent timeouts in test javax/net/ssl/Stapling/HttpsUrlConnClient.java (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28784/head:pull/28784
$ git checkout pull/28784

Update a local copy of the PR:
$ git checkout pull/28784
$ git pull https://git.openjdk.org/jdk.git pull/28784/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28784

View PR using the GUI difftool:
$ git pr show -t 28784

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28784.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 12, 2025

👋 Welcome back azeller! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 12, 2025

@ArnoZeller This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8371559: Intermittent timeouts in test javax/net/ssl/Stapling/HttpsUrlConnClient.java

Reviewed-by: mbaesken, myankelevich

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 38 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@myankelev, @MBaesken) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the security security-dev@openjdk.org label Dec 12, 2025
@openjdk
Copy link

openjdk bot commented Dec 12, 2025

@ArnoZeller The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 12, 2025
@mlbridge
Copy link

mlbridge bot commented Dec 12, 2025

Webrevs

@myankelev
Copy link
Member

Actually, what do you think about changing this test to utilise a countdownlatch instead of serverReady boolean?
This way we can get rid of the sleep all together, as there is still a chance of the same error happening

@ArnoZeller
Copy link
Contributor Author

Actually, what do you think about changing this test to utilise a countdownlatch instead of serverReady boolean? This way we can get rid of the sleep all together, as there is still a chance of the same error happening

I changed the test accordingly and resolved the wildcard imports. Please have a look.

@myankelev
Copy link
Member

Thank you for you changes, this looks good to me

@ArnoZeller
Copy link
Contributor Author

@myankelev : Thanks a lot for your suggestions and the review - I will now let this pull request run for two days in our test system to see if our issues are completely solved.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 17, 2025
@ArnoZeller
Copy link
Contributor Author

ArnoZeller commented Dec 17, 2025

I have seen no issues in our test landscape with this PR.

@ArnoZeller
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Dec 17, 2025
@openjdk
Copy link

openjdk bot commented Dec 17, 2025

@ArnoZeller
Your change (at version 40c09e1) is now ready to be sponsored by a Committer.

@ArnoZeller
Copy link
Contributor Author

Thanks @myankelev and @MBaesken for the reviews. Would one of you be so nice to sponsor this change?

@MBaesken
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Dec 17, 2025

Going to push as commit af18fbd.
Since your change was applied there have been 38 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 17, 2025
@openjdk openjdk bot closed this Dec 17, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Dec 17, 2025
@openjdk
Copy link

openjdk bot commented Dec 17, 2025

@MBaesken @ArnoZeller Pushed as commit af18fbd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@xiezhaokun
Copy link
Member

/backport jdk21u-dev

@openjdk
Copy link

openjdk bot commented Jan 29, 2026

@xiezhaokun the backport was successfully created on the branch backport-xiezhaokun-af18fbd4-master in my personal fork of openjdk/jdk21u-dev. To create a pull request with this backport targeting openjdk/jdk21u-dev:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit af18fbd4 from the openjdk/jdk repository.

The commit being backported was authored by Arno Zeller on 17 Dec 2025 and was reviewed by Matthias Baesken and Mikhail Yankelevich.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk21u-dev:

$ git fetch https://github.com/openjdk-bots/jdk21u-dev.git backport-xiezhaokun-af18fbd4-master:backport-xiezhaokun-af18fbd4-master
$ git checkout backport-xiezhaokun-af18fbd4-master
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk21u-dev.git backport-xiezhaokun-af18fbd4-master

⚠️ @xiezhaokun You are not yet a collaborator in my fork openjdk-bots/jdk21u-dev. An invite will be sent out and you need to accept it before you can proceed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated security security-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

4 participants