Skip to content

8373579: Problem list compiler/runtime/Test7196199.java#28787

Closed
benoitmaillard wants to merge 2 commits intoopenjdk:masterfrom
benoitmaillard:JDK-8373579
Closed

8373579: Problem list compiler/runtime/Test7196199.java#28787
benoitmaillard wants to merge 2 commits intoopenjdk:masterfrom
benoitmaillard:JDK-8373579

Conversation

@benoitmaillard
Copy link
Contributor

@benoitmaillard benoitmaillard commented Dec 12, 2025

Problem list compiler/runtime/Test7196199.java until JDK-8365196 is fixed.

Thank you for reviewing!


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8373579: Problem list compiler/runtime/Test7196199.java (Sub-task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28787/head:pull/28787
$ git checkout pull/28787

Update a local copy of the PR:
$ git checkout pull/28787
$ git pull https://git.openjdk.org/jdk.git pull/28787/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28787

View PR using the GUI difftool:
$ git pr show -t 28787

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28787.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 12, 2025

👋 Welcome back bmaillard! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 12, 2025

@benoitmaillard This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8373579: Problem list compiler/runtime/Test7196199.java

Reviewed-by: chagedorn, epeter

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 180d8c1: 8372746: Some httpserver files could benefit from some formatting cleanup

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title 8373579 8373579: Problem list compiler/runtime/Test7196199.java Dec 12, 2025
@openjdk
Copy link

openjdk bot commented Dec 12, 2025

@benoitmaillard this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout JDK-8373579
git fetch https://git.openjdk.org/jdk.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk openjdk bot added the merge-conflict Pull request has merge conflict with target branch label Dec 12, 2025
@openjdk
Copy link

openjdk bot commented Dec 12, 2025

@benoitmaillard To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • net
  • nio
  • security
  • serviceability
  • shenandoah

@openjdk openjdk bot removed the merge-conflict Pull request has merge conflict with target branch label Dec 12, 2025
@benoitmaillard
Copy link
Contributor Author

/label add hotspot-compiler

@benoitmaillard benoitmaillard marked this pull request as ready for review December 12, 2025 12:05
@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Dec 12, 2025
@openjdk
Copy link

openjdk bot commented Dec 12, 2025

@benoitmaillard
The hotspot-compiler label was successfully added.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 12, 2025
Copy link
Member

@chhagedorn chhagedorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and trivial.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 12, 2025
@mlbridge
Copy link

mlbridge bot commented Dec 12, 2025

Webrevs

Copy link
Contributor

@eme64 eme64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Though in the PR description you mentioned ProblemList.txt, when you probably meant to mention the test, right?

@benoitmaillard
Copy link
Contributor Author

benoitmaillard commented Dec 12, 2025

Looks good. Though in the PR description you mentioned ProblemList.txt, when you probably meant to mention the test, right?

My bad, yes of course. Thanks @eme64 @chhagedorn!

@benoitmaillard
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Dec 12, 2025

Going to push as commit a05d5d2.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 180d8c1: 8372746: Some httpserver files could benefit from some formatting cleanup

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 12, 2025
@openjdk openjdk bot closed this Dec 12, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 12, 2025
@openjdk
Copy link

openjdk bot commented Dec 12, 2025

@benoitmaillard Pushed as commit a05d5d2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@benoitmaillard
Copy link
Contributor Author

/backport :jdk26

@openjdk
Copy link

openjdk bot commented Dec 12, 2025

@benoitmaillard the backport was successfully created on the branch backport-benoitmaillard-a05d5d25-jdk26 in my personal fork of openjdk/jdk. To create a pull request with this backport targeting openjdk/jdk:jdk26, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit a05d5d25 from the openjdk/jdk repository.

The commit being backported was authored by Benoît Maillard on 12 Dec 2025 and was reviewed by Christian Hagedorn and Emanuel Peter.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk:

$ git fetch https://github.com/openjdk-bots/jdk.git backport-benoitmaillard-a05d5d25-jdk26:backport-benoitmaillard-a05d5d25-jdk26
$ git checkout backport-benoitmaillard-a05d5d25-jdk26
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk.git backport-benoitmaillard-a05d5d25-jdk26

⚠️ @benoitmaillard You are not yet a collaborator in my fork openjdk-bots/jdk. An invite will be sent out and you need to accept it before you can proceed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants