Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8263190: Update java.io, java.math, and java.text to use instanceof pattern variable #2879

Closed
wants to merge 1 commit into from

Conversation

@pconcannon
Copy link
Contributor

@pconcannon pconcannon commented Mar 8, 2021

Hi,

Could someone please review my code for updating the code in the java.io, java.math, and java.text packages to make use of the instanceof pattern variable?

Kind regards,
Patrick


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8263190: Update java.io, java.math, and java.text to use instanceof pattern variable

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2879/head:pull/2879
$ git checkout pull/2879

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Mar 8, 2021

👋 Welcome back pconcannon! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Mar 8, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Mar 8, 2021

@pconcannon The following labels will be automatically applied to this pull request:

  • core-libs
  • i18n
  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Mar 8, 2021

Webrevs

@mlbridge
Copy link

@mlbridge mlbridge bot commented Mar 8, 2021

Mailing list message from Brian Goetz on security-dev:

Looks good!? Glad to see the Amber features finding their way into the
codebase.

On 3/8/2021 1:53 PM, Patrick Concannon wrote:

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/security-dev/attachments/20210308/48637f0e/attachment.htm>

Copy link
Contributor

@LanceAndersen LanceAndersen left a comment

Looks good

@openjdk
Copy link

@openjdk openjdk bot commented Mar 8, 2021

@pconcannon This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8263190: Update java.io, java.math, and java.text to use instanceof pattern variable

Reviewed-by: lancea, bpb, darcy, naoto, iris, dfuchs, smarks, redestad

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • eb4a8af: 8260664: Phaser.arrive() memory consistency effects
  • 9221540: 8213269: convert test/hotspot/jtreg/runtime/memory/RunUnitTestsConcurrently to gtest
  • 17853ee: 8263200: Add -XX:StressCCP to CTW
  • a2b8858: 8263041: Shenandoah: Cleanup C1 keep alive barrier check

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Mar 8, 2021
bplb
bplb approved these changes Mar 8, 2021
Copy link
Member

@bplb bplb left a comment

Looks good and builds cleanly: approved.

jddarcy
jddarcy approved these changes Mar 8, 2021
naotoj
naotoj approved these changes Mar 8, 2021
dfuch
dfuch approved these changes Mar 8, 2021
cl4es
cl4es approved these changes Mar 8, 2021
@pconcannon
Copy link
Contributor Author

@pconcannon pconcannon commented Mar 9, 2021

/integrate

@openjdk openjdk bot closed this Mar 9, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Mar 9, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Mar 9, 2021

@pconcannon Since your change was applied there have been 14 commits pushed to the master branch:

  • 4f0a12e: 8262323: do not special case JVMCI in tiered compilation policy
  • 3022baa: 8263167: IGV: build fails with "taskdef AutoUpdate cannot be found"
  • 0bc4562: 8263068: Rename safefetch.hpp to safefetch.inline.hpp
  • 5bfc5fd: 8263051: Modernize the code in the java.awt.color package
  • 5b9b170: 8262955: Unify os::fork_and_exec() across Posix platforms
  • 39b1113: 8262161: Refactor manual I/O stream copying in java.desktop to use new convenience APIs
  • 4e94760: 8263135: unique_ptr should not be used for types that are not pointers
  • f71b21b: 8263038: Optimize String.format for simple specifiers
  • 14cfbda: 8261366: Add discussion of IEEE 754 to BigDecimal
  • 414ee95: 8261462: GCM ByteBuffer decryption problems
  • ... and 4 more: https://git.openjdk.java.net/jdk/compare/1f9ed9059f929cf3dd411ca291a9940f32aaea02...master

Your commit was automatically rebased without conflicts.

Pushed as commit 0f2402d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@pconcannon pconcannon deleted the JDK-8263190 branch May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment