Skip to content

8373593: Support latest VS2026 MSC_VER in abstract_vm_version.cpp#28792

Closed
MBaesken wants to merge 1 commit intoopenjdk:masterfrom
MBaesken:JDK-8373593
Closed

8373593: Support latest VS2026 MSC_VER in abstract_vm_version.cpp#28792
MBaesken wants to merge 1 commit intoopenjdk:masterfrom
MBaesken:JDK-8373593

Conversation

@MBaesken
Copy link
Member

@MBaesken MBaesken commented Dec 12, 2025

VS2026 has been released recently and support in the OpenJDK build has been introduced with JDK-8371967. The compiler has a new _MSC_VER = 1950 which should be covered in abstract_vm_version.cpp .


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

  • JDK-8373593: Support latest VS2026 MSC_VER in abstract_vm_version.cpp (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28792/head:pull/28792
$ git checkout pull/28792

Update a local copy of the PR:
$ git checkout pull/28792
$ git pull https://git.openjdk.org/jdk.git pull/28792/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28792

View PR using the GUI difftool:
$ git pr show -t 28792

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28792.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 12, 2025

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 12, 2025

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8373593: Support latest  VS2026 MSC_VER in abstract_vm_version.cpp

Reviewed-by: mdoerr, dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 77 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title JDK-8373593: Support latest VS2026 MSC_VER in abstract_vm_version.cpp 8373593: Support latest VS2026 MSC_VER in abstract_vm_version.cpp Dec 12, 2025
@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Dec 12, 2025
@openjdk
Copy link

openjdk bot commented Dec 12, 2025

@MBaesken The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 12, 2025
@mlbridge
Copy link

mlbridge bot commented Dec 12, 2025

Webrevs

Copy link
Contributor

@TheRealMDoerr TheRealMDoerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'm not a Windows build expert.
/reviewers 2

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 15, 2025
@openjdk
Copy link

openjdk bot commented Dec 15, 2025

@TheRealMDoerr
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Dec 15, 2025
@MBaesken
Copy link
Member Author

Thanks Martin ! It is a HS change (a very small one but still a HS change), so we need one more reviewer anyway!

@MBaesken
Copy link
Member Author

@erikj79 , @dholmes-ora any comments ?

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine. Thanks

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 17, 2025
@MBaesken
Copy link
Member Author

Thanks for the reviews !

/integrate

@openjdk
Copy link

openjdk bot commented Dec 18, 2025

Going to push as commit a31e6e0.
Since your change was applied there have been 87 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 18, 2025
@openjdk openjdk bot closed this Dec 18, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 18, 2025
@openjdk
Copy link

openjdk bot commented Dec 18, 2025

@MBaesken Pushed as commit a31e6e0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants