8373593: Support latest VS2026 MSC_VER in abstract_vm_version.cpp#28792
8373593: Support latest VS2026 MSC_VER in abstract_vm_version.cpp#28792MBaesken wants to merge 1 commit intoopenjdk:masterfrom
Conversation
|
👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into |
|
@MBaesken This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 77 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
TheRealMDoerr
left a comment
There was a problem hiding this comment.
LGTM, but I'm not a Windows build expert.
/reviewers 2
|
@TheRealMDoerr |
|
Thanks Martin ! It is a HS change (a very small one but still a HS change), so we need one more reviewer anyway! |
|
@erikj79 , @dholmes-ora any comments ? |
|
Thanks for the reviews ! /integrate |
|
Going to push as commit a31e6e0.
Your commit was automatically rebased without conflicts. |
VS2026 has been released recently and support in the OpenJDK build has been introduced with JDK-8371967. The compiler has a new
_MSC_VER = 1950which should be covered in abstract_vm_version.cpp .Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28792/head:pull/28792$ git checkout pull/28792Update a local copy of the PR:
$ git checkout pull/28792$ git pull https://git.openjdk.org/jdk.git pull/28792/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 28792View PR using the GUI difftool:
$ git pr show -t 28792Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28792.diff
Using Webrev
Link to Webrev Comment