Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8252195: AWT Accessibility API nested classes rely on default constructors #288

Closed
wants to merge 3 commits into from
Closed

Conversation

prrace
Copy link
Contributor

@prrace prrace commented Sep 21, 2020

https://bugs.openjdk.java.net/browse/JDK-8252195
is another one of the issues adding missing explicit no-args constructors in the desktop module.

As well as being nested, these are all concrete, but protected, classes and so the constructors
are protected.

CSR here https://bugs.openjdk.java.net/browse/JDK-8253450 needs a reviewer too.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8252195: AWT Accessibility API nested classes rely on default constructors

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/288/head:pull/288
$ git checkout pull/288

@prrace
Copy link
Contributor Author

prrace commented Sep 21, 2020

/csr

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 21, 2020

👋 Welcome back prr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the csr Pull request needs approved CSR before integration label Sep 21, 2020
@openjdk
Copy link

openjdk bot commented Sep 21, 2020

@prrace this pull request will not be integrated until the CSR request JDK-8253450 for issue JDK-8252195 has been approved.

@openjdk
Copy link

openjdk bot commented Sep 21, 2020

@prrace The following labels will be automatically applied to this pull request: 2d awt i18n.

When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label (add|remove) "label" command.

@openjdk openjdk bot added 2d client-libs-dev@openjdk.org i18n i18n-dev@openjdk.org awt client-libs-dev@openjdk.org labels Sep 21, 2020
@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 21, 2020
@mlbridge
Copy link

mlbridge bot commented Sep 21, 2020

Webrevs

@@ -0,0 +1,17 @@
-rw-r--r-- 1 prrace staff 22640 Sep 21 12:12 CheckboxMenuItem.java
Copy link
Member

@mrserb mrserb Sep 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This extra file seems accidentally added

@prrace
Copy link
Contributor Author

prrace commented Sep 22, 2020

extra file deleted. That'll teach me not to do 'git add '

@openjdk openjdk bot removed the csr Pull request needs approved CSR before integration label Sep 22, 2020
mrserb
mrserb approved these changes Sep 22, 2020
@openjdk
Copy link

openjdk bot commented Sep 22, 2020

@prrace This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements

After integration, the commit message will be:

8252195: AWT Accessibility API nested classes rely on default constructors

Reviewed-by: serb
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 22 commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 426c9049cefa4e7c809054705c2da477e598a292.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 22, 2020
@prrace
Copy link
Contributor Author

prrace commented Sep 22, 2020

/integrate

@openjdk openjdk bot closed this Sep 22, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 22, 2020
@openjdk
Copy link

openjdk bot commented Sep 22, 2020

@prrace Since your change was applied there have been 22 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

Pushed as commit 93a2018.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@prrace prrace deleted the a11y_nested branch Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2d client-libs-dev@openjdk.org awt client-libs-dev@openjdk.org i18n i18n-dev@openjdk.org integrated Pull request has been integrated
2 participants