8373537: Migrate "test/jdk/com/sun/net/httpserver/" to null-safe "SimpleSSLContext" methods#28800
8373537: Migrate "test/jdk/com/sun/net/httpserver/" to null-safe "SimpleSSLContext" methods#28800vy wants to merge 6 commits intoopenjdk:masterfrom
Conversation
|
👋 Welcome back vyazici! A progress list of the required criteria for merging this PR into |
|
@vy This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 3 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
dfuch
left a comment
There was a problem hiding this comment.
You could maybe have taken advantage of the dependent PR feature here to avoid showing SimpleSSLContext changes in the PR. OK with what you did though. Just a few minor remarks otherwise LGTM.
test/jdk/com/sun/net/httpserver/simpleserver/HttpsServerAlertTest.java
Outdated
Show resolved
Hide resolved
test/jdk/com/sun/net/httpserver/simpleserver/HttpsServerTest.java
Outdated
Show resolved
Hide resolved
dfuch
left a comment
There was a problem hiding this comment.
LGTM. Obviously don't integrate before JDK-8372661.
|
@dfuch, thanks so much for the review.
/integrate |
|
Going to push as commit 14c93b2.
Your commit was automatically rebased without conflicts. |
Migrates
test/jdk/com/sun/net/httpserver/to null-safeSimpleSSLContextmethods introduced in [JDK-8372661], which is a prerequisite for this change set.Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28800/head:pull/28800$ git checkout pull/28800Update a local copy of the PR:
$ git checkout pull/28800$ git pull https://git.openjdk.org/jdk.git pull/28800/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 28800View PR using the GUI difftool:
$ git pr show -t 28800Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28800.diff
Using Webrev
Link to Webrev Comment