Skip to content

8373537: Migrate "test/jdk/com/sun/net/httpserver/" to null-safe "SimpleSSLContext" methods#28800

Closed
vy wants to merge 6 commits intoopenjdk:masterfrom
vy:simpleSslHs
Closed

8373537: Migrate "test/jdk/com/sun/net/httpserver/" to null-safe "SimpleSSLContext" methods#28800
vy wants to merge 6 commits intoopenjdk:masterfrom
vy:simpleSslHs

Conversation

@vy
Copy link
Contributor

@vy vy commented Dec 12, 2025

Migrates test/jdk/com/sun/net/httpserver/ to null-safe SimpleSSLContext methods introduced in [JDK-8372661], which is a prerequisite for this change set.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8373537: Migrate "test/jdk/com/sun/net/httpserver/" to null-safe "SimpleSSLContext" methods (Sub-task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28800/head:pull/28800
$ git checkout pull/28800

Update a local copy of the PR:
$ git checkout pull/28800
$ git pull https://git.openjdk.org/jdk.git pull/28800/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28800

View PR using the GUI difftool:
$ git pr show -t 28800

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28800.diff

Using Webrev

Link to Webrev Comment

@vy vy marked this pull request as ready for review December 12, 2025 19:31
@bridgekeeper
Copy link

bridgekeeper bot commented Dec 12, 2025

👋 Welcome back vyazici! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 12, 2025

@vy This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8373537: Migrate "test/jdk/com/sun/net/httpserver/" to null-safe "SimpleSSLContext" methods

Reviewed-by: dfuchs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 7a7e7c9: 8373877: QUIC connections are removed too early
  • b848ddf: 8373110: jstack --mixed frames are broken on macOS after JDK-8371194
  • 3258e4d: 8373068: Revisit details of Float16 to decimal conversion algorithm

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added security security-dev@openjdk.org net net-dev@openjdk.org labels Dec 12, 2025
@openjdk
Copy link

openjdk bot commented Dec 12, 2025

@vy The following labels will be automatically applied to this pull request:

  • net
  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 12, 2025
@mlbridge
Copy link

mlbridge bot commented Dec 12, 2025

Webrevs

Copy link
Member

@dfuch dfuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could maybe have taken advantage of the dependent PR feature here to avoid showing SimpleSSLContext changes in the PR. OK with what you did though. Just a few minor remarks otherwise LGTM.

Copy link
Member

@dfuch dfuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Obviously don't integrate before JDK-8372661.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 16, 2025
@vy
Copy link
Contributor Author

vy commented Dec 19, 2025

@dfuch, thanks so much for the review.

/integrate

@openjdk
Copy link

openjdk bot commented Dec 19, 2025

Going to push as commit 14c93b2.
Since your change was applied there have been 14 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 19, 2025
@openjdk openjdk bot closed this Dec 19, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 19, 2025
@openjdk
Copy link

openjdk bot commented Dec 19, 2025

@vy Pushed as commit 14c93b2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@vy vy deleted the simpleSslHs branch January 6, 2026 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated net net-dev@openjdk.org security security-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

3 participants