8262351: Extra '0' in java.util.Formatter for '%012a' conversion with a sign character

[igraves]

This fixes a zero-adding issue observed in the hex float conversion.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8262351: Extra '0' in java.util.Formatter for '%012a' conversion with a sign character

Reviewers

• Brent Christian (@bchristi-git - Reviewer)
• Naoto Sato (@naotoj - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2881/head:pull/2881
$ git checkout pull/2881

[bridgekeeper]

👋 Welcome back igraves! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@igraves The following labels will be automatically applied to this pull request:

• core-libs
• i18n

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (308ae14)
• 00: Full (441c790)

[bchristi-git]

This all looks fine - just update the copyright year in Formatter.java, please.

In my personal opinion, this behavior change does not rise to the level of needing a CSR, but since it is long-standing behavior, you might double-check with Joe.

[naotoj]

Looks good to me.
BTW apart from this issue, I just noticed that in the chart in the Formatter class spec, there are two spaces (two NBSPs) for the extra space flag:

 * <tr><th scope="row" style="vertical-align:top"> <code>'&nbsp;&nbsp;'</code>
 *     <td style="vertical-align:top"> <code>'&#92;u0020'</code>
 *     <td> Requires the output to include a single extra space
 *     (<code>'&#92;u0020'</code>) for non-negative values.
 *
 *     <p> If both the {@code '+'} and <code>'&nbsp;&nbsp;'</code> flags are given
 *     then an {@link IllegalFormatFlagsException} will be thrown.

This might be fixed sometime.

[openjdk]

@igraves This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8262351: Extra '0' in java.util.Formatter for '%012a' conversion with a sign character

Reviewed-by: bchristi, naoto

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 35 new commits pushed to the master branch:

• 57f16f9: 8262377: Parallel class resolution loses constant pool error
• b482733: 8259218: (fs) Add links in from overloaded methods in java.nio.file.Files
• acda812: 8263333: Improve links from core reflection to JLS and JVMS
• 9399e1b: 8261918: two runtime/cds/appcds/VerifierTest failed with "Unable to use shared archive"
• 7e52a6e: 8263380: Unintended use of Objects.nonNull in VarHandles
• 4b5be40: 8238812: assert(false) failed: bad AD file
• b2a2ddf: 8262438: sun/security/ssl/SSLLogger/LoggingFormatConsistency.java failed with "SocketException: Socket is closed"
• c8c0234: 8262471: Fix coding style in src/java.base/share/classes/java/lang/CharacterDataPrivateUse.java
• 4d21a45: 8262913: KlassFactory::create_from_stream should never return NULL
• fab5676: 8247869: Change NONCOPYABLE to delete the operations
• ... and 25 more: https://git.openjdk.java.net/jdk/compare/eb4a8af559cae9374d29617053a1113ac4b7de2e...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@bchristi-git, @naotoj) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[igraves]

/csr

[openjdk]

@igraves has indicated that a compatibility and specification (CSR) request is needed for this pull request.
@igraves please create a CSR request and add link to it in JDK-8262351. This pull request cannot be integrated until the CSR request is approved.

[igraves]

/integrate

[openjdk]

@igraves
Your change (at version 308ae14) is now ready to be sponsored by a Committer.

[bchristi-git]

/sponsor

[openjdk]

@bchristi-git @igraves Since your change was applied there have been 36 commits pushed to the master branch:

• c6d74bd: 8262910: Cleanup THREAD/TRAPS/naming and typing issues in ObjectMonitor and related code
• 57f16f9: 8262377: Parallel class resolution loses constant pool error
• b482733: 8259218: (fs) Add links in from overloaded methods in java.nio.file.Files
• acda812: 8263333: Improve links from core reflection to JLS and JVMS
• 9399e1b: 8261918: two runtime/cds/appcds/VerifierTest failed with "Unable to use shared archive"
• 7e52a6e: 8263380: Unintended use of Objects.nonNull in VarHandles
• 4b5be40: 8238812: assert(false) failed: bad AD file
• b2a2ddf: 8262438: sun/security/ssl/SSLLogger/LoggingFormatConsistency.java failed with "SocketException: Socket is closed"
• c8c0234: 8262471: Fix coding style in src/java.base/share/classes/java/lang/CharacterDataPrivateUse.java
• 4d21a45: 8262913: KlassFactory::create_from_stream should never return NULL
• ... and 26 more: https://git.openjdk.java.net/jdk/compare/eb4a8af559cae9374d29617053a1113ac4b7de2e...master

Your commit was automatically rebased without conflicts.

Pushed as commit 6971c23.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.