Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8261916: gtest/GTestWrapper.java vmErrorTest.unimplemented1_vm_asset failed #2884

Closed
wants to merge 1 commit into from

Conversation

coleenp
Copy link
Contributor

@coleenp coleenp commented Mar 8, 2021

Some post-vm hooks were interfering with the gtests that expect exceptions to be thrown. When running gtests, disable postVMInitHooks.
Tested with failing tests and configurations, and tier1 on linux-x64, linux-aarch64, macos-x64, windows-x64, and their -debug equivalents.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Integration blocker

 ⚠️ Title mismatch between PR and JBS for issue JDK-8261916

Issue

  • JDK-8261916: gtest/GTestWrapper.java vmErrorTest.unimplemented1_vm_assert failed ⚠️ Title mismatch between PR and JBS.

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2884/head:pull/2884
$ git checkout pull/2884

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 8, 2021

👋 Welcome back coleenp! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 8, 2021
@openjdk
Copy link

openjdk bot commented Mar 8, 2021

@coleenp The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Mar 8, 2021
@mlbridge
Copy link

mlbridge bot commented Mar 8, 2021

Webrevs

@coleenp coleenp closed this Mar 9, 2021
@coleenp coleenp deleted the gtest branch March 9, 2021 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.org rfr Pull request is ready for review
1 participant