8373798: Refactor java/math tests to use JUnit

[rgiulietti]

Replace testng framework with junit

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8373798: Refactor java/math tests to use JUnit (Sub-task - P4)

Reviewers

• Joe Darcy (@jddarcy - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28848/head:pull/28848
$ git checkout pull/28848

Update a local copy of the PR:
$ git checkout pull/28848
$ git pull https://git.openjdk.org/jdk.git pull/28848/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28848

View PR using the GUI difftool:
$ git pr show -t 28848

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28848.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back rgiulietti! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@rgiulietti This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8373798: Refactor java/math tests to use JUnit

Reviewed-by: darcy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 17 new commits pushed to the master branch:

• 76e79db: 8371716: C2: Phi node fails Value()'s verification when speculative types clash
• 89e7751: 8370922: Template Framework Library: Float16 type and operations
• a61394b: 8373789: No PCH release build failure after JDK-8372543
• ... and 14 more: https://git.openjdk.org/jdk/compare/34f241317ecd7473cfb6dcc2e6e5cf3a40299e2c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@rgiulietti The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (e576d6da)

[AlanBateman]

If you want, you could use NumberFormatException nfe = assertThrows(..) here, then assert the cause. That would avoid mixing JUnit asserts with explicit throw of RuntimeException.

[rgiulietti]

That's just the result of a mechanical conversion of the original testng-based code.

[AlanBateman]

Okay, but you could go the extra mile and replace the throw of RuntimeException as it looks very strange to have the test be a JUnit test and still have this.

[rgiulietti]

It is my plan to review all numerics related tests, rewriting some of those that do not use any framework to use junit in the end.
For now, the priority is to remove the dependencies on testng.

[jddarcy]

Looks fine.

[rgiulietti]

/integrate

[openjdk]

Going to push as commit fc76403.
Since your change was applied there have been 35 commits pushed to the master branch:

• af18fbd: 8371559: Intermittent timeouts in test javax/net/ssl/Stapling/HttpsUrlConnClient.java
• 4924b29: 8370655: Check EINTR handling InetAddress implementation and NET_ThrowNew
• 9e2008b: 8373676: Test javax/net/ssl/HttpsURLConnection/SubjectAltNameIP.java fails on a machine without IPV6
• ... and 32 more: https://git.openjdk.org/jdk/compare/34f241317ecd7473cfb6dcc2e6e5cf3a40299e2c...master

Your commit was automatically rebased without conflicts.

[openjdk]

@rgiulietti Pushed as commit fc76403.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.