Skip to content

6517125: FontStrike.getGlyphVectorOutline() not used#28856

Closed
gredler wants to merge 1 commit intoopenjdk:masterfrom
gredler:delete-get-glyph-vector-outline
Closed

6517125: FontStrike.getGlyphVectorOutline() not used#28856
gredler wants to merge 1 commit intoopenjdk:masterfrom
gredler:delete-get-glyph-vector-outline

Conversation

@gredler
Copy link
Contributor

@gredler gredler commented Dec 16, 2025

This method is not used and can be deleted from the entire FontStrike class hierarchy. There was some discussion in 2007 about re-enabling if there were performance benefits, but 20 years have passed and no performance issues have emerged. In fact, the macOS OpenJDK never implemented this method.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-6517125: FontStrike.getGlyphVectorOutline() not used (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28856/head:pull/28856
$ git checkout pull/28856

Update a local copy of the PR:
$ git checkout pull/28856
$ git pull https://git.openjdk.org/jdk.git pull/28856/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28856

View PR using the GUI difftool:
$ git pr show -t 28856

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28856.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 16, 2025

👋 Welcome back dgredler! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 16, 2025

@gredler This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

6517125: FontStrike.getGlyphVectorOutline() not used

Reviewed-by: prr, serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 146 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Dec 16, 2025
@openjdk
Copy link

openjdk bot commented Dec 16, 2025

@gredler The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 16, 2025
@mlbridge
Copy link

mlbridge bot commented Dec 16, 2025

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 19, 2025
@gredler
Copy link
Contributor Author

gredler commented Dec 26, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Dec 26, 2025

Going to push as commit e65ace1.
Since your change was applied there have been 148 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 26, 2025
@openjdk openjdk bot closed this Dec 26, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 26, 2025
@openjdk
Copy link

openjdk bot commented Dec 26, 2025

@gredler Pushed as commit e65ace1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client client-libs-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants