8263170: ComboBoxModel documentation refers to a nonexistent type

[prsadhuk]

javadoc of ComboBoxModel incorrectly specifies "extends ListDataModel" but actually it extends ListModel and there is no such interface as ListDataModel. Rectified the anomaly.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8263170: ComboBoxModel documentation refers to a nonexistent type

Reviewers

• Alexander Zvegintsev (@azvegint - Reviewer) ⚠️ Review applies to 68b4fbe
• Tejpal Rebari (@trebari - Committer) ⚠️ Review applies to 68b4fbe
• Pankaj Bansal (@pankaj-bansal - Reviewer) ⚠️ Review applies to 68b4fbe
• Alexey Ivanov (@aivanov-jdk - Reviewer) ⚠️ Review applies to 68b4fbe
• Alexander Zuev (@azuev-java - Reviewer) ⚠️ Review applies to 68b4fbe

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2886/head:pull/2886
$ git checkout pull/2886

[bridgekeeper]

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@prsadhuk The following label will be automatically applied to this pull request:

• swing

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (87c8939)
• 00: Full (68b4fbe)

[openjdk]

@prsadhuk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8263170: ComboBoxModel documentation refers to a nonexistent type

Reviewed-by: azvegint, trebari, pbansal, aivanov, kizune

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 373 new commits pushed to the master branch:

• 67ea3bd: 8263102: Expand documention of Method.isBridge
• d0c1aec: 8263140: Japanese chars garble in console window in HSDB
• 70342e8: 8262520: Add SA Command Line Debugger support to connect to debug server
• e5ce97b: 8263206: assert(*error_msg != '\0') failed: Must have error_message while parsing -XX:CompileCommand=unknown
• 3212f80: 8261937: LambdaForClassInBaseArchive: SimpleApp$$Lambda$1 missing
• 2218e72: 8262486: Merge trivial JDWP agent changes from the loom repo to the jdk repo
• 86fac95: 8263142: Delete unused entry points in libawt/libawt_xawt/libawt_headless
• b7f0b3f: 8252173: Use handles instead of jobjects in modules.cpp
• a6e34b3: 8262829: Native crash in Win32PrintServiceLookup.getAllPrinterNames()
• fbe40e8: 8252399: Update mapMulti documentation to use type test pattern instead of instanceof once JEP 375 exits preview
• ... and 363 more: https://git.openjdk.java.net/jdk/compare/5183d8ae1eec86202eace2c4770f81edbc73cb68...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[mrserb]

I suggest always update the copyright.

[prsadhuk]

/integrate

[openjdk]

@prsadhuk Since your change was applied there have been 374 commits pushed to the master branch:

• d8a9c3c: 8263002: Remove CDS MiscCode region
• 67ea3bd: 8263102: Expand documention of Method.isBridge
• d0c1aec: 8263140: Japanese chars garble in console window in HSDB
• 70342e8: 8262520: Add SA Command Line Debugger support to connect to debug server
• e5ce97b: 8263206: assert(*error_msg != '\0') failed: Must have error_message while parsing -XX:CompileCommand=unknown
• 3212f80: 8261937: LambdaForClassInBaseArchive: SimpleApp$$Lambda$1 missing
• 2218e72: 8262486: Merge trivial JDWP agent changes from the loom repo to the jdk repo
• 86fac95: 8263142: Delete unused entry points in libawt/libawt_xawt/libawt_headless
• b7f0b3f: 8252173: Use handles instead of jobjects in modules.cpp
• a6e34b3: 8262829: Native crash in Win32PrintServiceLookup.getAllPrinterNames()
• ... and 364 more: https://git.openjdk.java.net/jdk/compare/5183d8ae1eec86202eace2c4770f81edbc73cb68...master

Your commit was automatically rebased without conflicts.

Pushed as commit 3fe8a46.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[turbanoff]

There is one more occurrence of ListDataModel in JDK code - https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/classes/javax/swing/ListModel.java#L34
Perhaps it's worth to fix it too.

[prsadhuk]

There is one more occurrence of ListDataModel in JDK code - https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/classes/javax/swing/ListModel.java#L34
Perhaps it's worth to fix it too.

ok. will take a look.