8263055: hsdb Command Line Debugger does not properly direct output for some commands

[plummercj]

I ran the hsdb Command Line Debugger (Windows -> Console menu item) and tried the class and classes commands, and neither appeared to produce any output. Other commands seemed to work as expected. I then went back to the terminal window I used to launch hsdb, and notice all the output from class and classes commands went there instead. The reason is because these commands are using System.out.println instead of out.println. "out" is a PrintStream field of the CommandProcessor instance, and should be used for all output other than error output, which can use "err".

We have no test for this, but I did run the hsdb GUI, brought up the Command Line Debugger, and confirmed that class and classes now properly show the output there. We do have clhsdb tests that also exercise this CommandProcessor code, but clhsdb directs all the output to System.out, so out.println and System.out.println end up being the same, thus the issue was not noticed.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8263055: hsdb Command Line Debugger does not properly direct output for some commands

Reviewers

• Alex Menkov (@alexmenkov - Reviewer)
• Yasumasa Suenaga (@YaSuenag - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2887/head:pull/2887
$ git checkout pull/2887

[bridgekeeper]

👋 Welcome back cjplummer! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@plummercj The following label will be automatically applied to this pull request:

• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (e534335)

[openjdk]

@plummercj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8263055: hsdb Command Line Debugger does not properly direct output for some commands

Reviewed-by: amenkov, ysuenaga

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 73 new commits pushed to the master branch:

• cf1c021: 8263480: ProblemList two jpackage tests on Windows
• f3bd801: 8263403: [JVMCI] output written to tty via HotSpotJVMCIRuntime can be garbled
• b92abac: 8263433: Shenandoah: Don't expect forwarded objects in set_concurrent_mark_in_progress()
• 15dacca: 8263465: JDK-8236847 causes tier1 build failure on linux-aarch64
• 7ed46bd: 8241716: Jpackage functionality to let users choose whether to create shortcuts
• 3820ab9: 8236847: CDS archive with 4K alignment unusable on machines with 64k pages
• 273f8bd: 8263248: IGV: accept graphs without node categories
• a9b4f03: 8263069: Exclude some failing tests from security/infra/java/security/cert/CertPathValidator
• 470b150: 8143041: Unify G1CollectorPolicy::PauseKind and G1YCType
• f6b4ba0: 8261931: IGV: quick search fails on multi-line node labels
• ... and 63 more: https://git.openjdk.java.net/jdk/compare/e1cad97049642ab201d53ff608937f7e7ef3ff3e...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[plummercj]

Thanks, Yasumasa and Alex!

[plummercj]

/integrate

[openjdk]

@plummercj Since your change was applied there have been 87 commits pushed to the master branch:

• ecfa712: 8263326: Remove ReceiverTypeData check from serviceability/sa/TestPrintMdo.java
• b932a62: 8263470: Consolidate copies of getClassBytes in various tests
• 0ea48d9: 8194129: Regression automated Test '/open/test/jdk/java/awt/Window/ShapedAndTranslucentWindows/TranslucentChoice.java' fails
• 4b5c664: 8178348: left_n_bits(0) invokes undefined behavior
• 0b10c6b: 8263017: Read barriers are missing in nmethod printing code
• a6e056f: 8263125: During deoptimization vectors should reassign scalarized payload after all objects are reallocated.
• 65421fa: 8213177: GlobalCounter::CSContext could be an enum class
• a9b156d: 8258414: OldObjectSample events too expensive
• 0bbe064: 8263354: Accumulated C2 code cleanups
• aa33443: 8262454: Handshake timeout improvements, single target, kill unfinished thread
• ... and 77 more: https://git.openjdk.java.net/jdk/compare/e1cad97049642ab201d53ff608937f7e7ef3ff3e...master

Your commit was automatically rebased without conflicts.

Pushed as commit b2f7c58.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.