8373877: QUIC connections are removed too early

[djelinski]

When a QUIC connection receives a CONNECTION_CLOSE frame, it is supposed to enter the draining state, where all incoming (reordered / replayed) packets are silently discarded. However, the current implementation removes the connection from the endpoint, and reordered/replayed packets trigger sending of a stateless reset instead. This patch fixes that issue.

I modified the StatelessResetReceiptTest to verify that the connection is still registered with the endpoint after it enters the draining state. The new test fails (most of the time) without the fix, passes with the fix.

Existing httpclient tests continue to pass.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8373877: QUIC connections are removed too early (Bug - P4)

Reviewers

• Daniel Fuchs (@dfuch - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28874/head:pull/28874
$ git checkout pull/28874

Update a local copy of the PR:
$ git checkout pull/28874
$ git pull https://git.openjdk.org/jdk.git pull/28874/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28874

View PR using the GUI difftool:
$ git pr show -t 28874

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28874.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back djelinski! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@djelinski This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8373877: QUIC connections are removed too early

Reviewed-by: dfuchs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

• 9862f8f: 8373513: C2: Move ProjNode::other_if_proj() to IfProjNode
• 39306d7: 8373800: Remove ScopedValueBindingsResolver
• 5e7ae28: 8373677: Clear text HttpServer connection could fail fast if receiving SSL ClientHello

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@djelinski The following label will be automatically applied to this pull request:

• net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (c6d53f5b)

[dfuch]

Looks good to me. We now only enter draining when we receive ConnectionCloseFrame, if we haven't sent ConnectionCloseFrame already.
If we are already in draining state, nothing to do.
If we are already in closing state, then we stay in closing state.
Looks good.

[djelinski]

Thanks @dfuch for the review.

/integrate

[openjdk]

Going to push as commit 7a7e7c9.
Since your change was applied there have been 27 commits pushed to the master branch:

• b848ddf: 8373110: jstack --mixed frames are broken on macOS after JDK-8371194
• 3258e4d: 8373068: Revisit details of Float16 to decimal conversion algorithm
• 629e4ac: 8372661: Add a null-safe static factory method to "jdk.test.lib.net.SimpleSSLContext"
• ... and 24 more: https://git.openjdk.org/jdk/compare/e4636d69e7e41477619a163e97fd3af2e5942dde...master

Your commit was automatically rebased without conflicts.

[openjdk]

@djelinski Pushed as commit 7a7e7c9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.