8373917: test/hotspot/jtreg/vmTestbase/nsk/monitoring: -iterations setting misused in tests#28876
8373917: test/hotspot/jtreg/vmTestbase/nsk/monitoring: -iterations setting misused in tests#28876kevinjwalls wants to merge 1 commit intoopenjdk:masterfrom
Conversation
…tting misused in tests
|
👋 Welcome back kevinw! A progress list of the required criteria for merging this PR into |
|
@kevinjwalls This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 89 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
@kevinjwalls To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command. Applicable Labels
|
|
/label serviceability |
|
@kevinjwalls |
|
Thanks Leonid! |
|
/integrate |
|
Going to push as commit 97f4f00.
Your commit was automatically rebased without conflicts. |
|
@kevinjwalls Pushed as commit 97f4f00. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Some tests in test/hotspot/jtreg/vmTestbase/nsk tests are misusing the -iterations command-line option: it is parsed only as "-iterations x" rather than "-iterations=x"
Fixing the RunParams parsing to recognise this saves updating multiple tests.
Other options are "option=value" so accepting -iterations=number is what we might expect (and is what tests are currently written to use).
The change makes logs look correct. No more "Iterations: 0".
There are tests that currently log "Iterations: 0" but still do some work, so this is partly cosmetic, but also if you were thinking of making a test do some set limited number of iterations, you can now follow the example of other tests and have it work.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28876/head:pull/28876$ git checkout pull/28876Update a local copy of the PR:
$ git checkout pull/28876$ git pull https://git.openjdk.org/jdk.git pull/28876/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 28876View PR using the GUI difftool:
$ git pr show -t 28876Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28876.diff
Using Webrev
Link to Webrev Comment