Skip to content

8373917: test/hotspot/jtreg/vmTestbase/nsk/monitoring: -iterations setting misused in tests#28876

Closed
kevinjwalls wants to merge 1 commit intoopenjdk:masterfrom
kevinjwalls:8373917_iterations
Closed

8373917: test/hotspot/jtreg/vmTestbase/nsk/monitoring: -iterations setting misused in tests#28876
kevinjwalls wants to merge 1 commit intoopenjdk:masterfrom
kevinjwalls:8373917_iterations

Conversation

@kevinjwalls
Copy link
Contributor

@kevinjwalls kevinjwalls commented Dec 17, 2025

Some tests in test/hotspot/jtreg/vmTestbase/nsk tests are misusing the -iterations command-line option: it is parsed only as "-iterations x" rather than "-iterations=x"

Fixing the RunParams parsing to recognise this saves updating multiple tests.

Other options are "option=value" so accepting -iterations=number is what we might expect (and is what tests are currently written to use).

The change makes logs look correct. No more "Iterations: 0".

There are tests that currently log "Iterations: 0" but still do some work, so this is partly cosmetic, but also if you were thinking of making a test do some set limited number of iterations, you can now follow the example of other tests and have it work.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8373917: test/hotspot/jtreg/vmTestbase/nsk/monitoring: -iterations setting misused in tests (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28876/head:pull/28876
$ git checkout pull/28876

Update a local copy of the PR:
$ git checkout pull/28876
$ git pull https://git.openjdk.org/jdk.git pull/28876/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28876

View PR using the GUI difftool:
$ git pr show -t 28876

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28876.diff

Using Webrev

Link to Webrev Comment

@kevinjwalls kevinjwalls marked this pull request as ready for review December 17, 2025 18:27
@bridgekeeper
Copy link

bridgekeeper bot commented Dec 17, 2025

👋 Welcome back kevinw! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 17, 2025

@kevinjwalls This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8373917: test/hotspot/jtreg/vmTestbase/nsk/monitoring: -iterations setting misused in tests

Reviewed-by: lmesnik

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 89 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk
Copy link

openjdk bot commented Dec 17, 2025

@kevinjwalls To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • net
  • nio
  • security
  • serviceability
  • shenandoah

@kevinjwalls
Copy link
Contributor Author

/label serviceability

@openjdk openjdk bot added the serviceability serviceability-dev@openjdk.org label Dec 17, 2025
@openjdk
Copy link

openjdk bot commented Dec 17, 2025

@kevinjwalls
The serviceability label was successfully added.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 17, 2025
@mlbridge
Copy link

mlbridge bot commented Dec 17, 2025

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 30, 2025
@kevinjwalls
Copy link
Contributor Author

Thanks Leonid!

@kevinjwalls
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Dec 31, 2025

Going to push as commit 97f4f00.
Since your change was applied there have been 92 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 31, 2025
@openjdk openjdk bot closed this Dec 31, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 31, 2025
@openjdk
Copy link

openjdk bot commented Dec 31, 2025

@kevinjwalls Pushed as commit 97f4f00.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated serviceability serviceability-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

2 participants