8373847: Test javax/swing/JMenuItem/MenuItemTest/bug6197830.java failed because The test case automatically fails when clicking any items in the “Nothing” menu in all four windows (Left-to-right)-Menu Item Test and (Right-to-left)-Menu Item Test

[prsadhuk]

When user selects any menu item from "No nothing". the following exception happens because PassFailJFrame logArea is not created

java.lang.NullPointerException: Cannot invoke "javax.swing.JTextArea.append(String)" because "PassFailJFrame.logArea" is null
at PassFailJFrame.lambda$log$0(PassFailJFrame.java:1353)
at PassFailJFrame.invokeOnEDT(PassFailJFrame.java:570)
at PassFailJFrame.invokeOnEDTUncheckedException(PassFailJFrame.java:584)
at PassFailJFrame.log(PassFailJFrame.java:1353)
at MenuItemTestHelper.lambda$createNoNothingMenu$0(MenuItemTestHelper.java:118) 

Fix is to create log area

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8373847: Test javax/swing/JMenuItem/MenuItemTest/bug6197830.java failed because The test case automatically fails when clicking any items in the “Nothing” menu in all four windows (Left-to-right)-Menu Item Test and (Right-to-left)-Menu Item Test (Bug - P4)

Reviewers

• Sergey Bylokhov (@mrserb - Reviewer)
• Alexey Ivanov (@aivanov-jdk - Reviewer)
• Damon Nguyen (@DamonGuy - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28887/head:pull/28887
$ git checkout pull/28887

Update a local copy of the PR:
$ git checkout pull/28887
$ git pull https://git.openjdk.org/jdk.git pull/28887/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28887

View PR using the GUI difftool:
$ git pr show -t 28887

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28887.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@prsadhuk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8373847: Test javax/swing/JMenuItem/MenuItemTest/bug6197830.java failed because The test case automatically fails when clicking any items in the “Nothing” menu in all four windows (Left-to-right)-Menu Item Test and (Right-to-left)-Menu Item Test

Reviewed-by: serb, aivanov, dnguyen

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 118 new commits pushed to the master branch:

• 08450f2: 8374326: Update copyright year to 2025 for jdk.jpackage in files where it was missed
• 92c6799: 8374361: Update copyright year to 2025 for jdk.hotspot.agent in files where it was missed
• 078e71f: 8344345: test/hotspot/gtest/x86/x86-asmtest.py has trailing whitespaces
• ... and 115 more: https://git.openjdk.org/jdk/compare/78c2d57259ad829a2cfc1370efbb2a5913df4661...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@prsadhuk The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[prsadhuk]

/touch

[openjdk]

@prsadhuk The pull request is being re-evaluated and the inactivity timeout has been reset.

[mlbridge]

Webrevs

• 00: Full (1be89ccd)

[prsadhuk]

/touch

[openjdk]

@prsadhuk The pull request is being re-evaluated and the inactivity timeout has been reset.

[prsadhuk]

/integrate

[openjdk]

Going to push as commit 05d2f7f.
Since your change was applied there have been 133 commits pushed to the master branch:

• 2ea3c00: 4337898: Serializing DefaultTableCellRenderer changes colors
• 65af6bc: 8374371: Failed assertion in G1HeapRegion gtest
• d9bd300: 8374382: (aio) AsynchronousFileChannel writes wrong content using heap ByteBuffer when position != 0
• ... and 130 more: https://git.openjdk.org/jdk/compare/78c2d57259ad829a2cfc1370efbb2a5913df4661...master

Your commit was automatically rebased without conflicts.

[openjdk]

@prsadhuk Pushed as commit 05d2f7f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.