Skip to content

8373909: JSpec and ToolGuide taglets use incorrect relative path#28902

Closed
dansmithcode wants to merge 1 commit intoopenjdk:jdk26from
openjdk-bots:backport-dansmithcode-0b271240-jdk26
Closed

8373909: JSpec and ToolGuide taglets use incorrect relative path#28902
dansmithcode wants to merge 1 commit intoopenjdk:jdk26from
openjdk-bots:backport-dansmithcode-0b271240-jdk26

Conversation

@dansmithcode
Copy link

@dansmithcode dansmithcode commented Dec 18, 2025

This pull request contains a backport of commit 0b271240 from the openjdk/jdk repository.

The commit being backported was authored by Dan Smith on 18 Dec 2025 and was reviewed by Chen Liang and Hannes Wallnöfer.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8373909: JSpec and ToolGuide taglets use incorrect relative path (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28902/head:pull/28902
$ git checkout pull/28902

Update a local copy of the PR:
$ git checkout pull/28902
$ git pull https://git.openjdk.org/jdk.git pull/28902/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28902

View PR using the GUI difftool:
$ git pr show -t 28902

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28902.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 18, 2025

👋 Welcome back dlsmith! A progress list of the required criteria for merging this PR into jdk26 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 18, 2025

@dansmithcode This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8373909: JSpec and ToolGuide taglets use incorrect relative path

Reviewed-by: liach

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the jdk26 branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the jdk26 branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 0b2712400b55d4a512db225d090c2f06f01f7f1f 8373909: JSpec and ToolGuide taglets use incorrect relative path Dec 18, 2025
@openjdk
Copy link

openjdk bot commented Dec 18, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required javadoc javadoc-dev@openjdk.org build build-dev@openjdk.org labels Dec 18, 2025
@openjdk
Copy link

openjdk bot commented Dec 18, 2025

@dansmithcode The following labels will be automatically applied to this pull request:

  • build
  • javadoc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 18, 2025
@mlbridge
Copy link

mlbridge bot commented Dec 18, 2025

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 18, 2025
@dansmithcode
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented Dec 18, 2025

Going to push as commit fb7d25d.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 18, 2025
@openjdk openjdk bot closed this Dec 18, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 18, 2025
@openjdk
Copy link

openjdk bot commented Dec 18, 2025

@dansmithcode Pushed as commit fb7d25d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base build build-dev@openjdk.org clean Identical backport; no merge resolution required integrated Pull request has been integrated javadoc javadoc-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

2 participants