Skip to content

8374044: Docs build fails: Cannot determine current path#28909

Closed
dansmithcode wants to merge 1 commit intoopenjdk:masterfrom
dansmithcode:8374044
Closed

8374044: Docs build fails: Cannot determine current path#28909
dansmithcode wants to merge 1 commit intoopenjdk:masterfrom
dansmithcode:8374044

Conversation

@dansmithcode
Copy link

@dansmithcode dansmithcode commented Dec 18, 2025

Adding the needed -XDaccessInternalAPI to the alternate "reference" list of javadoc args.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8374044: Docs build fails: Cannot determine current path (Bug - P2)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28909/head:pull/28909
$ git checkout pull/28909

Update a local copy of the PR:
$ git checkout pull/28909
$ git pull https://git.openjdk.org/jdk.git pull/28909/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28909

View PR using the GUI difftool:
$ git pr show -t 28909

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28909.diff

Using Webrev

Link to Webrev Comment

@dansmithcode
Copy link
Author

/label javadoc

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 18, 2025

👋 Welcome back dlsmith! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 18, 2025

@dansmithcode This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8374044: Docs build fails: Cannot determine current path

Reviewed-by: dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 8a93658: 8371284: GenShen: Avoid unnecessary card marking

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the javadoc javadoc-dev@openjdk.org label Dec 18, 2025
@openjdk
Copy link

openjdk bot commented Dec 18, 2025

@dansmithcode
The javadoc label was successfully added.

@openjdk openjdk bot added the build build-dev@openjdk.org label Dec 18, 2025
@openjdk
Copy link

openjdk bot commented Dec 18, 2025

@dansmithcode The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 18, 2025
@liach
Copy link
Member

liach commented Dec 18, 2025

@irisclark Since you are known for using docs-reference to compare the specdiff between Java SE releases, can you review this?

@mlbridge
Copy link

mlbridge bot commented Dec 18, 2025

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 18, 2025
@dansmithcode
Copy link
Author

/integrate

@dansmithcode
Copy link
Author

/backport :jdk26

@openjdk
Copy link

openjdk bot commented Dec 18, 2025

Going to push as commit f88cbfb.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 8a93658: 8371284: GenShen: Avoid unnecessary card marking

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 18, 2025
@openjdk openjdk bot closed this Dec 18, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 18, 2025
@openjdk
Copy link

openjdk bot commented Dec 18, 2025

@dansmithcode Pushed as commit f88cbfb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@openjdk
Copy link

openjdk bot commented Dec 18, 2025

@dansmithcode the backport was successfully created on the branch backport-dansmithcode-f88cbfb8-jdk26 in my personal fork of openjdk/jdk. To create a pull request with this backport targeting openjdk/jdk:jdk26, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit f88cbfb8 from the openjdk/jdk repository.

The commit being backported was authored by Dan Smith on 18 Dec 2025 and was reviewed by David Holmes.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk:

$ git fetch https://github.com/openjdk-bots/jdk.git backport-dansmithcode-f88cbfb8-jdk26:backport-dansmithcode-f88cbfb8-jdk26
$ git checkout backport-dansmithcode-f88cbfb8-jdk26
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk.git backport-dansmithcode-f88cbfb8-jdk26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build build-dev@openjdk.org integrated Pull request has been integrated javadoc javadoc-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

3 participants