8373105: Test tools/jpackage/share/AsyncTest.java failed: problem running hdiutil

[sashamatveev]

• I was not able to reproduce this issue.
• Based on log we calling same detach command simultaneously:

[08:49:10.288] TRACE: exec: Execute [/usr/bin/hdiutil detach -force -verbose /Volumes/Foo](5); discard out+err...
[08:49:10.274] TRACE: exec: Execute [/usr/bin/hdiutil detach -force -verbose /Volumes/Foo](5); discard out+err...

• I think hdiutil does not handle attaching/detaching DMG with same name asynchronously multiple times well enough.
• Fixed by mounting DMG into random location.
• Added -nobrowse, so DMG will not be added to Finder. We do not need DMG to be shown in Finder when attached during test.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8373105: Test tools/jpackage/share/AsyncTest.java failed: problem running hdiutil (Bug - P4)

Reviewers

• Alexey Semenyuk (@alexeysemenyukoracle - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28912/head:pull/28912
$ git checkout pull/28912

Update a local copy of the PR:
$ git checkout pull/28912
$ git pull https://git.openjdk.org/jdk.git pull/28912/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28912

View PR using the GUI difftool:
$ git pr show -t 28912

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28912.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back almatvee! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@sashamatveev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8373105: Test tools/jpackage/share/AsyncTest.java failed: problem running hdiutil

Reviewed-by: asemenyuk

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 37 new commits pushed to the master branch:

• 400d8cf: 8373793: TestDynamicStore.java '/manual' disables use of '/timeout'
• c1ad393: 8374048: Genshen: Backout fix for missed cancellation notice
• 23fc21a: 8374052: Use java/util/Calendar in ReplaceCriticalClasses.java test
• ... and 34 more: https://git.openjdk.org/jdk/compare/ea5834415db6410c73271c496811ff6b5dcc87ef...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@sashamatveev The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (cdba5272)
• 00: Full (c4583ecd)

[sashamatveev]

@alexeysemenyukoracle Please review.

[alexeysemenyukoracle]

I once suspected jpackage's DMG attach/detach code was not very reliable, as the fixed volume name is used and filed JDK-8371494 to investigate. Back then, as I never observed AsyncTest failures, I closed the CR as not an issue. It merely took some time to reveal the problem.

We need both jpackage and the test code fixed.

[sashamatveev]

We do not need to fix jpackage. It is already uses random mount root. Example from trace:

/usr/bin/hdiutil attach /var/folders/dr/65dj5x3j0296mqtsn9z27xc80000gn/T/jdk.jpackage8052723072987214442/dmg-workdir/proto.dmg -verbose -mountroot /var/folders/dr/65dj5x3j0296mqtsn9z27xc80000gn/T/jdk.jpackage8052723072987214442/dmg-workdir

[alexeysemenyukoracle]

Oh, right. The issue is with the hdiutil attach command, not with hdiutil create.

[alexeysemenyukoracle]

Temporary test files should be created in the test working directory. Use TKit.createTempDirectory("mount-root") instead.

It also makes the newly added TKit.deleteDirectoryRecursive(mountRoot, ""); call redundant, as the test working directory will be deleted automatically when the test exits.

TKit.createTempDirectory() throws unchecked exceptions; the try/catch is redundant.

[sashamatveev]

8373105: Test tools/jpackage/share/AsyncTest.java failed: problem running hdiutil [v2]

• TKit.createTempDirectory("mount-root") will be used instead of Files.createTempDirectory("mount-root")

[sashamatveev]

/integrate

[openjdk]

Going to push as commit 2d09284.
Since your change was applied there have been 38 commits pushed to the master branch:

• 0a70da4: 8372564: Convert StringDedup to use Atomic
• 400d8cf: 8373793: TestDynamicStore.java '/manual' disables use of '/timeout'
• c1ad393: 8374048: Genshen: Backout fix for missed cancellation notice
• ... and 35 more: https://git.openjdk.org/jdk/compare/ea5834415db6410c73271c496811ff6b5dcc87ef...master

Your commit was automatically rebased without conflicts.

[openjdk]

@sashamatveev Pushed as commit 2d09284.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.