8374082: net_util.c should use logical && when setting IPv6_available

[jaikiran]

Can I please get a review of this change which replaces the use of & with && in net_util.c?

As noted in https://bugs.openjdk.org/browse/JDK-8374082, the use of bitwise operator appears to be an oversight in that code.

tier1, tier2 testing passed without any issues after this change.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8374082: net_util.c should use logical && when setting IPv6_available (Bug - P4)

Reviewers

• Alan Bateman (@AlanBateman - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28918/head:pull/28918
$ git checkout pull/28918

Update a local copy of the PR:
$ git checkout pull/28918
$ git pull https://git.openjdk.org/jdk.git pull/28918/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28918

View PR using the GUI difftool:
$ git pr show -t 28918

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28918.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jpai! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@jaikiran This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8374082: net_util.c should use logical && when setting IPv6_available

Reviewed-by: alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@jaikiran The following label will be automatically applied to this pull request:

• net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (c656f543)

[jaikiran]

Thank you Alan for the review. tier1, tier2 and tier3 continue to pass with this change and since this is a trivial change, I'll go ahead with the integration.

[jaikiran]

/integrate

[openjdk]

Going to push as commit 45cf042.
Since your change was applied there have been 2 commits pushed to the master branch:

• 5eb8774: 8373998: RISC-V: simple optimization of ConvHF2F
• e72f205: 8373524: C2: no reachable node should have no use

Your commit was automatically rebased without conflicts.

[openjdk]

@jaikiran Pushed as commit 45cf042.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.