Skip to content

8373246: JDK-8351842 broke native debugging on Linux#28926

Closed
RealCLanger wants to merge 1 commit intoopenjdk:jdk26from
openjdk-bots:backport-RealCLanger-b5ac8f83-jdk26
Closed

8373246: JDK-8351842 broke native debugging on Linux#28926
RealCLanger wants to merge 1 commit intoopenjdk:jdk26from
openjdk-bots:backport-RealCLanger-b5ac8f83-jdk26

Conversation

@RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Dec 19, 2025

Hi all,

This pull request contains a backport of JDK-8373246, commit b5ac8f83 from the openjdk/jdk repository.

The commit being backported was authored by Christoph Langer on 19 Dec 2025 and was reviewed by Erik Joelsson and Thomas Stuefe.

Thanks!


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8373246: JDK-8351842 broke native debugging on Linux (Bug - P2)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28926/head:pull/28926
$ git checkout pull/28926

Update a local copy of the PR:
$ git checkout pull/28926
$ git pull https://git.openjdk.org/jdk.git pull/28926/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28926

View PR using the GUI difftool:
$ git pr show -t 28926

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28926.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 19, 2025

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into jdk26 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 19, 2025

@RealCLanger This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8373246: JDK-8351842 broke native debugging on Linux

Reviewed-by: erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the jdk26 branch:

  • d5dde3f: 8373946: Synth ProgressBarUI implementation confuses background painting with border painting
  • 1ec4ff5: 8373630: r18_tls should not be modified on Windows AArch64

Please see this link for an up-to-date comparison between the source branch of this pull request and the jdk26 branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the jdk26 branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport b5ac8f83682ddb9623a1b43bd62f309b2961a504 8373246: JDK-8351842 broke native debugging on Linux Dec 19, 2025
@openjdk
Copy link

openjdk bot commented Dec 19, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required build build-dev@openjdk.org labels Dec 19, 2025
@openjdk
Copy link

openjdk bot commented Dec 19, 2025

@RealCLanger The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 19, 2025
@mlbridge
Copy link

mlbridge bot commented Dec 19, 2025

Webrevs

@erikj79
Copy link
Member

erikj79 commented Dec 19, 2025

I will approve this later today when I've verified that the original change didn't cause any issues in our mainline CI.

@RealCLanger
Copy link
Contributor Author

I will approve this later today when I've verified that the original change didn't cause any issues in our mainline CI.

Sure, no need to rush, I'll also give it some time to bake in our CI.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 19, 2025
@judovana
Copy link
Contributor

/backport jdk26u

@openjdk
Copy link

openjdk bot commented Dec 22, 2025

@judovana Backport for repo openjdk/jdk26u on branch master was successfully enabled and will be performed once this pull request has been integrated. Further instructions will be provided at that time.

@RealCLanger
Copy link
Contributor Author

Thanks for the review. Ran successfully through our testing.

/integrate

@RealCLanger
Copy link
Contributor Author

/backport jdk26u

@judovana This is not necessary, change will be merged to jdk26u automatically...

@openjdk
Copy link

openjdk bot commented Dec 22, 2025

Going to push as commit 6d9e91f.
Since your change was applied there have been 2 commits pushed to the jdk26 branch:

  • d5dde3f: 8373946: Synth ProgressBarUI implementation confuses background painting with border painting
  • 1ec4ff5: 8373630: r18_tls should not be modified on Windows AArch64

Your commit was automatically rebased without conflicts.

@openjdk
Copy link

openjdk bot commented Dec 22, 2025

Creating backport for repo openjdk/jdk26u on branch master

/backport openjdk/jdk26u master

@openjdk openjdk bot added integrated Pull request has been integrated and removed backport=openjdk/jdk26u:master labels Dec 22, 2025
@openjdk openjdk bot closed this Dec 22, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 22, 2025
@openjdk
Copy link

openjdk bot commented Dec 22, 2025

@RealCLanger Pushed as commit 6d9e91f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@openjdk
Copy link

openjdk bot commented Dec 22, 2025

@openjdk[bot] @judovana the backport was successfully created on the branch backport-judovana-6d9e91f8-master in my personal fork of openjdk/jdk26u. To create a pull request with this backport targeting openjdk/jdk26u:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 6d9e91f8 from the openjdk/jdk repository.

The commit being backported was authored by Christoph Langer on 22 Dec 2025 and was reviewed by Erik Joelsson.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk26u:

$ git fetch https://github.com/openjdk-bots/jdk26u.git backport-judovana-6d9e91f8-master:backport-judovana-6d9e91f8-master
$ git checkout backport-judovana-6d9e91f8-master
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk26u.git backport-judovana-6d9e91f8-master

⚠️ @judovana You are not yet a collaborator in my fork openjdk-bots/jdk26u. An invite will be sent out and you need to accept it before you can proceed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base build build-dev@openjdk.org clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants