8374216: Assorted changes to jpackage without functional impact

[alexeysemenyukoracle]

Miscellaneous refactorings without functional changes:

• Replace StringBuffer with StringBuilder where appropriate
• LauncherBuilder: set reasonable defaults to "defaultIconResourceName" property; move defaultIconResourceName() from LauncherFromOptions
• Make MacHelper.createRuntimeBundle() use PackageTest to create a runtime bundle. Will use DMG by default and optionally PKG packaging to create a runtime bundle
• Remove redundat parameter from SetBuilder.build()
• Make JUnitUtils.assertArrayEquals() permit null-s
• Add JPackageCommand.withToolProvider()
• Make some handy package-private methods in StandardBundlingOperation class public
• BundleSpec: add "sealed" modifier
• IdentityWrapper: add wrapIdentity()
• Simplify DefaultBundlingEnvironment.createNativePackage()
• TKit: remove "throws IOException" from createDirectories(); Replace TKit.createDirectories() with Files.createDirectories() where directory clean-up is not used

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8374216: Assorted changes to jpackage without functional impact (Enhancement - P4)

Reviewers

• Alexander Matveev (@sashamatveev - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28957/head:pull/28957
$ git checkout pull/28957

Update a local copy of the PR:
$ git checkout pull/28957
$ git pull https://git.openjdk.org/jdk.git pull/28957/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28957

View PR using the GUI difftool:
$ git pr show -t 28957

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28957.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back asemenyuk! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@alexeysemenyukoracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8374216: Assorted changes to jpackage without functional impact

Reviewed-by: almatvee

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

• ecb4234: 8373447: Suspicious sign extension after integer promotion in imageDecompressor.cpp

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@alexeysemenyukoracle The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 05: Full - Incremental (5b41d27d)
• 04: Full - Incremental (d36624d3)
• 03: Full - Incremental (9ab1bb00)
• 02: Full (5d43b18f)
• 01: Full - Incremental (65d9c176)
• 00: Full (e9583db1)

[openjdk]

@alexeysemenyukoracle Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

[alexeysemenyukoracle]

@sashamatveev PTAL

[openjdk]

@alexeysemenyukoracle Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

[sashamatveev]

Looks good with minor comments.

[sashamatveev]

Looks good.

[alexeysemenyukoracle]

/integrate

[openjdk]

Going to push as commit a0094f5.
Since your change was applied there has been 1 commit pushed to the master branch:

• ecb4234: 8373447: Suspicious sign extension after integer promotion in imageDecompressor.cpp

Your commit was automatically rebased without conflicts.

[openjdk]

@alexeysemenyukoracle Pushed as commit a0094f5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.