8374296: Comment clean up in os_linux.cpp#28963
8374296: Comment clean up in os_linux.cpp#28963kevinjwalls wants to merge 1 commit intoopenjdk:masterfrom
Conversation
|
👋 Welcome back kevinw! A progress list of the required criteria for merging this PR into |
|
@kevinjwalls This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 2 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
|
@kevinjwalls The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
TheRealMDoerr
left a comment
There was a problem hiding this comment.
Looks good and trivial. Thanks for cleaning it up!
|
Thanks! |
|
/integrate |
|
Going to push as commit 8d80bac.
Your commit was automatically rebased without conflicts. |
|
@kevinjwalls Pushed as commit 8d80bac. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
In src/hotspot/os/linux/os_linux.cpp this comment no longer shows where there is time support code:
////////////////////////////////////////////////////////////////////////////////
// time support
Orphaned since JDK-8372625, trivially remove.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28963/head:pull/28963$ git checkout pull/28963Update a local copy of the PR:
$ git checkout pull/28963$ git pull https://git.openjdk.org/jdk.git pull/28963/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 28963View PR using the GUI difftool:
$ git pr show -t 28963Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28963.diff
Using Webrev
Link to Webrev Comment