Skip to content

8374195: TestReplaceNarrowPhiWithBottomPhi fails on ppc64 platforms in (fast)debug#28964

Closed
TheRealMDoerr wants to merge 1 commit intoopenjdk:masterfrom
TheRealMDoerr:8374195_TestReplaceNarrowPhiWithBottomPhi
Closed

8374195: TestReplaceNarrowPhiWithBottomPhi fails on ppc64 platforms in (fast)debug#28964
TheRealMDoerr wants to merge 1 commit intoopenjdk:masterfrom
TheRealMDoerr:8374195_TestReplaceNarrowPhiWithBottomPhi

Conversation

@TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented Dec 23, 2025

This test makes assumptions about the C2 ideal graph which are not true for PPC64. We need to get tests green also in jdk26 where the new test has landed in the meantime, so simply disabling it for the platform.
Test improvements can be done later if needed.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8374195: TestReplaceNarrowPhiWithBottomPhi fails on ppc64 platforms in (fast)debug (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28964/head:pull/28964
$ git checkout pull/28964

Update a local copy of the PR:
$ git checkout pull/28964
$ git pull https://git.openjdk.org/jdk.git pull/28964/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28964

View PR using the GUI difftool:
$ git pr show -t 28964

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28964.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 23, 2025

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 23, 2025

@TheRealMDoerr This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8374195: TestReplaceNarrowPhiWithBottomPhi fails on ppc64 platforms in (fast)debug

Reviewed-by: mbaesken, jbechberger

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 23 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Dec 23, 2025
@openjdk
Copy link

openjdk bot commented Dec 23, 2025

@TheRealMDoerr The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 23, 2025
@mlbridge
Copy link

mlbridge bot commented Dec 23, 2025

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 25, 2025
@TheRealMDoerr
Copy link
Contributor Author

Thanks for the reviews! I'll also create a backport.
/integrate

@openjdk
Copy link

openjdk bot commented Dec 30, 2025

Going to push as commit e4e923a.
Since your change was applied there have been 23 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 30, 2025
@openjdk openjdk bot closed this Dec 30, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 30, 2025
@openjdk
Copy link

openjdk bot commented Dec 30, 2025

@TheRealMDoerr Pushed as commit e4e923a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@TheRealMDoerr TheRealMDoerr deleted the 8374195_TestReplaceNarrowPhiWithBottomPhi branch December 30, 2025 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants