8374195: TestReplaceNarrowPhiWithBottomPhi fails on ppc64 platforms in (fast)debug#28964
Conversation
|
👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into |
|
@TheRealMDoerr This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 23 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
@TheRealMDoerr The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
|
Thanks for the reviews! I'll also create a backport. |
|
Going to push as commit e4e923a.
Your commit was automatically rebased without conflicts. |
|
@TheRealMDoerr Pushed as commit e4e923a. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This test makes assumptions about the C2 ideal graph which are not true for PPC64. We need to get tests green also in jdk26 where the new test has landed in the meantime, so simply disabling it for the platform.
Test improvements can be done later if needed.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28964/head:pull/28964$ git checkout pull/28964Update a local copy of the PR:
$ git checkout pull/28964$ git pull https://git.openjdk.org/jdk.git pull/28964/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 28964View PR using the GUI difftool:
$ git pr show -t 28964Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28964.diff
Using Webrev
Link to Webrev Comment