8374217: Remove IO.java test from AOT ProblemList#28967
8374217: Remove IO.java test from AOT ProblemList#28967naotoj wants to merge 3 commits intoopenjdk:masterfrom
Conversation
|
👋 Welcome back naoto! A progress list of the required criteria for merging this PR into |
|
@naotoj This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
|
/label add hotspot-runtime |
Webrevs
|
|
@naotoj |
test/jdk/java/lang/IO/IO.java
Outdated
| /* | ||
| * @test | ||
| * @bug 8305457 8342936 8351435 8344706 8361613 | ||
| * @bug 8305457 8342936 8351435 8344706 8361613 8374217 |
There was a problem hiding this comment.
Hello Naoto, the changes look OK to me. However, the guidelines of using @bug for tests https://openjdk.org/guide/#jtreg say:
These bug ids refer to product bugs for which a fix is verified by this test. JBS issues that track changes to the test itself are not listed here.
So I think we shouldn't add this bug id here.
There was a problem hiding this comment.
You're right. Reverted the bug ID in the test
jaikiran
left a comment
There was a problem hiding this comment.
Thank you for the update, Naoto. This looks good to me.
|
Thanks for the reviews! |
|
Going to push as commit 27dbdec.
Your commit was automatically rebased without conflicts. |
Removing the test from AOT Problem List. The test
java/lang/IO/IO.javahad a dependency onjdk.internal.lemodule, but it was removed in JDK26(https://bugs.openjdk.org/browse/JDK-8361613). Apart from that, the test case itself has been modified to not emit AOT/CDS logging messages in order for the output comparing test to succeed.Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28967/head:pull/28967$ git checkout pull/28967Update a local copy of the PR:
$ git checkout pull/28967$ git pull https://git.openjdk.org/jdk.git pull/28967/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 28967View PR using the GUI difftool:
$ git pr show -t 28967Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28967.diff
Using Webrev
Link to Webrev Comment