8374382: (aio) AsynchronousFileChannel writes wrong content using heap ByteBuffer when position != 0#29010
8374382: (aio) AsynchronousFileChannel writes wrong content using heap ByteBuffer when position != 0#29010AlanBateman wants to merge 3 commits intoopenjdk:masterfrom
Conversation
|
👋 Welcome back alanb! A progress list of the required criteria for merging this PR into |
|
@AlanBateman This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 3 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
|
@AlanBateman The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
|
/integrate |
|
Going to push as commit d9bd300.
Your commit was automatically rebased without conflicts. |
|
@AlanBateman Pushed as commit d9bd300. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
|
/backport :jdk26 |
|
@AlanBateman the backport was successfully created on the branch backport-AlanBateman-d9bd300c-jdk26 in my personal fork of openjdk/jdk. To create a pull request with this backport targeting openjdk/jdk:jdk26, just click the following link: The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:
If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk: |
On Windows only, if AsynchronousFileChannel is used with a heap ByteBuffer with a non-0 buffer position then the AsynchronousFileChannel read/write methods don't work correctly when the buffer is "substituted" for the underlying I/O operation.
This is a regression in JDK 26 after JDK-8357847, missed as we didn't have tests that exercise this scenario.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/29010/head:pull/29010$ git checkout pull/29010Update a local copy of the PR:
$ git checkout pull/29010$ git pull https://git.openjdk.org/jdk.git pull/29010/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 29010View PR using the GUI difftool:
$ git pr show -t 29010Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/29010.diff
Using Webrev
Link to Webrev Comment