Skip to content

8374382: (aio) AsynchronousFileChannel writes wrong content using heap ByteBuffer when position != 0#29010

Closed
AlanBateman wants to merge 3 commits intoopenjdk:masterfrom
AlanBateman:JDK-8374382
Closed

8374382: (aio) AsynchronousFileChannel writes wrong content using heap ByteBuffer when position != 0#29010
AlanBateman wants to merge 3 commits intoopenjdk:masterfrom
AlanBateman:JDK-8374382

Conversation

@AlanBateman
Copy link
Contributor

@AlanBateman AlanBateman commented Dec 31, 2025

On Windows only, if AsynchronousFileChannel is used with a heap ByteBuffer with a non-0 buffer position then the AsynchronousFileChannel read/write methods don't work correctly when the buffer is "substituted" for the underlying I/O operation.

This is a regression in JDK 26 after JDK-8357847, missed as we didn't have tests that exercise this scenario.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8374382: (aio) AsynchronousFileChannel writes wrong content using heap ByteBuffer when position != 0 (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/29010/head:pull/29010
$ git checkout pull/29010

Update a local copy of the PR:
$ git checkout pull/29010
$ git pull https://git.openjdk.org/jdk.git pull/29010/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 29010

View PR using the GUI difftool:
$ git pr show -t 29010

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/29010.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 31, 2025

👋 Welcome back alanb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 31, 2025

@AlanBateman This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8374382: (aio) AsynchronousFileChannel writes wrong content using heap ByteBuffer when position != 0

Reviewed-by: jpai

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • c6246d5: 8374383: Update the copyright year to 2025 in the remaining files under test/ where it was missed
  • 36d2c27: 8374327: Update copyright year to 2025 for files in java.base added/updated by commits in 2025
  • 3fd7bde: 8374378: Update copyright year to 2025 for jdk.internal.vm.ci in files where it was missed

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the nio nio-dev@openjdk.org label Dec 31, 2025
@openjdk
Copy link

openjdk bot commented Dec 31, 2025

@AlanBateman The following label will be automatically applied to this pull request:

  • nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@AlanBateman AlanBateman marked this pull request as ready for review December 31, 2025 07:42
@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 31, 2025
@mlbridge
Copy link

mlbridge bot commented Dec 31, 2025

Webrevs

Copy link
Member

@jaikiran jaikiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 31, 2025
@AlanBateman
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Jan 1, 2026

Going to push as commit d9bd300.
Since your change was applied there have been 10 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 1, 2026
@openjdk openjdk bot closed this Jan 1, 2026
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 1, 2026
@openjdk
Copy link

openjdk bot commented Jan 1, 2026

@AlanBateman Pushed as commit d9bd300.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@AlanBateman
Copy link
Contributor Author

/backport :jdk26

@openjdk
Copy link

openjdk bot commented Jan 2, 2026

@AlanBateman the backport was successfully created on the branch backport-AlanBateman-d9bd300c-jdk26 in my personal fork of openjdk/jdk. To create a pull request with this backport targeting openjdk/jdk:jdk26, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit d9bd300c from the openjdk/jdk repository.

The commit being backported was authored by Alan Bateman on 1 Jan 2026 and was reviewed by Jaikiran Pai.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk:

$ git fetch https://github.com/openjdk-bots/jdk.git backport-AlanBateman-d9bd300c-jdk26:backport-AlanBateman-d9bd300c-jdk26
$ git checkout backport-AlanBateman-d9bd300c-jdk26
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk.git backport-AlanBateman-d9bd300c-jdk26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated nio nio-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

2 participants