Skip to content

8374382: (aio) AsynchronousFileChannel writes wrong content using heap ByteBuffer when position != 0#29015

Closed
AlanBateman wants to merge 1 commit intoopenjdk:jdk26from
openjdk-bots:backport-AlanBateman-d9bd300c-jdk26
Closed

8374382: (aio) AsynchronousFileChannel writes wrong content using heap ByteBuffer when position != 0#29015
AlanBateman wants to merge 1 commit intoopenjdk:jdk26from
openjdk-bots:backport-AlanBateman-d9bd300c-jdk26

Conversation

@AlanBateman
Copy link
Contributor

@AlanBateman AlanBateman commented Jan 2, 2026

This pull request contains a clean backport of changeset d9bd300 from the openjdk/jdk repository.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8374382: (aio) AsynchronousFileChannel writes wrong content using heap ByteBuffer when position != 0 (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/29015/head:pull/29015
$ git checkout pull/29015

Update a local copy of the PR:
$ git checkout pull/29015
$ git pull https://git.openjdk.org/jdk.git pull/29015/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 29015

View PR using the GUI difftool:
$ git pr show -t 29015

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/29015.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 2, 2026

👋 Welcome back alanb! A progress list of the required criteria for merging this PR into jdk26 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 2, 2026

@AlanBateman This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8374382: (aio) AsynchronousFileChannel writes wrong content using heap ByteBuffer when position != 0

Reviewed-by: jpai

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the jdk26 branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the jdk26 branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport d9bd300c6eddfd30a83e53e7ae03c47ea43a9e08 8374382: (aio) AsynchronousFileChannel writes wrong content using heap ByteBuffer when position != 0 Jan 2, 2026
@openjdk
Copy link

openjdk bot commented Jan 2, 2026

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required nio nio-dev@openjdk.org labels Jan 2, 2026
@openjdk
Copy link

openjdk bot commented Jan 2, 2026

@AlanBateman The following label will be automatically applied to this pull request:

  • nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@AlanBateman AlanBateman marked this pull request as ready for review January 2, 2026 07:30
@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 2, 2026
@mlbridge
Copy link

mlbridge bot commented Jan 2, 2026

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 2, 2026
@AlanBateman
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Jan 3, 2026

Going to push as commit 6950503.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 3, 2026
@openjdk openjdk bot closed this Jan 3, 2026
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 3, 2026
@openjdk
Copy link

openjdk bot commented Jan 3, 2026

@AlanBateman Pushed as commit 6950503.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated nio nio-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

2 participants