Skip to content

8374433: java/util/Locale/PreserveTagCase.java does not run any tests#29021

Closed
naotoj wants to merge 1 commit intoopenjdk:masterfrom
naotoj:JDK-8374433-PreserveTagCase-not-run
Closed

8374433: java/util/Locale/PreserveTagCase.java does not run any tests#29021
naotoj wants to merge 1 commit intoopenjdk:masterfrom
naotoj:JDK-8374433-PreserveTagCase-not-run

Conversation

@naotoj
Copy link
Member

@naotoj naotoj commented Jan 2, 2026

Removing static from the JUnit test cases so that they are executed


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8374433: java/util/Locale/PreserveTagCase.java does not run any tests (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/29021/head:pull/29021
$ git checkout pull/29021

Update a local copy of the PR:
$ git checkout pull/29021
$ git pull https://git.openjdk.org/jdk.git pull/29021/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 29021

View PR using the GUI difftool:
$ git pr show -t 29021

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/29021.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 2, 2026

👋 Welcome back naoto! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 2, 2026

@naotoj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8374433: java/util/Locale/PreserveTagCase.java does not run any tests

Reviewed-by: iris, joehw, jlu

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added core-libs core-libs-dev@openjdk.org i18n i18n-dev@openjdk.org labels Jan 2, 2026
@openjdk
Copy link

openjdk bot commented Jan 2, 2026

@naotoj The following labels will be automatically applied to this pull request:

  • core-libs
  • i18n

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 2, 2026
@mlbridge
Copy link

mlbridge bot commented Jan 2, 2026

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 2, 2026
@naotoj
Copy link
Member Author

naotoj commented Jan 6, 2026

Thanks for the reviews!
/integrate

@openjdk
Copy link

openjdk bot commented Jan 6, 2026

Going to push as commit 136ac0d.
Since your change was applied there have been 22 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 6, 2026
@openjdk openjdk bot closed this Jan 6, 2026
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 6, 2026
@openjdk
Copy link

openjdk bot commented Jan 6, 2026

@naotoj Pushed as commit 136ac0d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core-libs core-libs-dev@openjdk.org i18n i18n-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

4 participants