8374434: Several JShell tests report JUnit discovery warnings

[lahodaj]

JShell tests where converted to use JUnit instead of TestNG by this commit:
b0ca9bf

As part of the conversion, the @Test annotation had to be copied from classes to test methods, as JUnit requires every test method to be annotated. Sadly the tool doing the conversion moved the annotation to some non-test methods as well. This PR fixes that. The tool has been fixed as well.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8374434: Several JShell tests report JUnit discovery warnings (Bug - P4)

Reviewers

• Jaikiran Pai (@jaikiran - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/29034/head:pull/29034
$ git checkout pull/29034

Update a local copy of the PR:
$ git checkout pull/29034
$ git pull https://git.openjdk.org/jdk.git pull/29034/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 29034

View PR using the GUI difftool:
$ git pr show -t 29034

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/29034.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jlahoda! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@lahodaj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8374434: Several JShell tests report JUnit discovery warnings

Reviewed-by: jpai

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 152 new commits pushed to the master branch:

• da14813: 8373453: C2 SuperWord: must handle load slices that have loads with different memory inputs
• 929864b: 8362087: Test containers/docker/ShareTmpDir.java intermittent fails
• d7a3df6: 8374436: compiler/igvn/IntegerDivValueTests.java failed with division by zero
• ... and 149 more: https://git.openjdk.org/jdk/compare/fc76403b01c4e801f2a58810deeec2a6ebfa8458...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@lahodaj The following label will be automatically applied to this pull request:

• compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (052e0583)
• 00: Full (ffd0df4f)

[jaikiran]

Hello Jan, this looks good to me.

In an upcoming jtreg release, issues like these will be easily noticed as this will lead to a test failure https://bugs.openjdk.org/browse/CODETOOLS-7904125.

The copyright years on these files will need an update before integrating.

[lahodaj]

Thanks for the review @jaikiran!

[lahodaj]

/integrate

[openjdk]

Going to push as commit e6abf98.
Since your change was applied there have been 160 commits pushed to the master branch:

• 9513758: 8374662: Remove unused type check functions from javaClasses.hpp
• 70669d0: 8374712: AOTMappedHeapWriter::relocate_field_in_buffer should use CompressedOops::narrow_oop_cast
• 0a1fa21: 8369150: NMethodRelocationTest fails when JVMTI events not published before JVM exit
• ... and 157 more: https://git.openjdk.org/jdk/compare/fc76403b01c4e801f2a58810deeec2a6ebfa8458...master

Your commit was automatically rebased without conflicts.

[openjdk]

@lahodaj Pushed as commit e6abf98.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.