8372377: Test java/io/File/GetXSpace.java failed: The system cannot find the path specified

[bplb]

If on Windows and the Space constructor fails with a RuntimeException, skip the volume if it is found not to exist. This has been found to be the case for all errors observed recently which appear to be due to the presence of transient volumes.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8372377: Test java/io/File/GetXSpace.java failed: The system cannot find the path specified (Bug - P4)

Reviewers

• Jaikiran Pai (@jaikiran - Reviewer) Review applies to dcdceeaf
• Alan Bateman (@AlanBateman - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/29052/head:pull/29052
$ git checkout pull/29052

Update a local copy of the PR:
$ git checkout pull/29052
$ git pull https://git.openjdk.org/jdk.git pull/29052/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 29052

View PR using the GUI difftool:
$ git pr show -t 29052

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/29052.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back bpb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@bplb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8372377: Test java/io/File/GetXSpace.java failed: The system cannot find the path specified

Reviewed-by: alanb, jpai

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 25 new commits pushed to the master branch:

• c1c0ac8: 8342772: Assert in LateInlineMHCallGenerator::do_late_inline_check
• 5c6947f: 8373429: gc/g1/TestCodeCacheUnloadDuringConcCycle fails on various platforms
• 6b3c1e0: 8373833: "error.cert.not.found" and "error.explicit-sign-no-cert" errors duplicate each other
• ... and 22 more: https://git.openjdk.org/jdk/compare/27dbdec297fc8030812f7290a7601b6a99defb46...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@bplb The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (faf3c269)
• 01: Full - Incremental (6fac6925)
• 00: Full (dcdceeaf)

[jaikiran]

Hello Brian, this looks OK to me. Would this same check be needed in the testFile() method where too the Space constructor gets called?

[AlanBateman]

What would you think about changing Space's constructor to throw IOException to remove the confusing RuntimeException from this test.

For testFile then I assume we should allow it to continue to fail. Something would be very broken in the test environment if the volume containing the temp dir disappears or fails while in use.

[bplb]

Hello Brian, this looks OK to me.

Thanks for the review, @jaikiran.

Would this same check be needed in the testFile() method where too the Space constructor gets called?

I don't think so as testFile() is called with a file that has a non-transient root.

[bplb]

What would you think about changing Space's constructor to throw IOException to remove the confusing RuntimeException from this test.

I had considered that. I will give it another look.

[bplb]

/integrate

[openjdk]

Going to push as commit 677572b.
Since your change was applied there have been 50 commits pushed to the master branch:

• ec65734: 8374641: Remove java/nio/channels/AsyncCloseAndInterrupt.java from problem list
• 78b1ca6: 8374711: Hotspot runtime/CommandLine/OptionsValidation/TestOptionsWithRanges fails without printing the option name
• c5159fc: 8374328: Convert simple AtomicAccess uses in gc/shared to use Atomic
• ... and 47 more: https://git.openjdk.org/jdk/compare/27dbdec297fc8030812f7290a7601b6a99defb46...master

Your commit was automatically rebased without conflicts.

[openjdk]

@bplb Pushed as commit 677572b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.