Skip to content

8373427: StructuredTaskScope::join not clear if called with interrupted status set#29059

Closed
AlanBateman wants to merge 2 commits intoopenjdk:masterfrom
AlanBateman:JDK-8373427
Closed

8373427: StructuredTaskScope::join not clear if called with interrupted status set#29059
AlanBateman wants to merge 2 commits intoopenjdk:masterfrom
AlanBateman:JDK-8373427

Conversation

@AlanBateman
Copy link
Contributor

@AlanBateman AlanBateman commented Jan 6, 2026

Small docs-only clarification to make it clearer that join throws InterruptedException if called with the current thread's interrupted status set. Also make it clear that the exception clears the interrupted status.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change requires CSR request JDK-8374578 to be approved
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issues

  • JDK-8373427: StructuredTaskScope::join not clear if called with interrupted status set (Bug - P3)
  • JDK-8374578: StructuredTaskScope::join not clear if called with interrupted status set (CSR)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/29059/head:pull/29059
$ git checkout pull/29059

Update a local copy of the PR:
$ git checkout pull/29059
$ git pull https://git.openjdk.org/jdk.git pull/29059/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 29059

View PR using the GUI difftool:
$ git pr show -t 29059

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/29059.diff

Using Webrev

Link to Webrev Comment

@AlanBateman
Copy link
Contributor Author

/csr

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 6, 2026

👋 Welcome back alanb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 6, 2026

@AlanBateman This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8373427: StructuredTaskScope::join not clear if called with interrupted status set

Reviewed-by: jpai

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 22 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the csr Pull request needs approved CSR before integration label Jan 6, 2026
@openjdk
Copy link

openjdk bot commented Jan 6, 2026

@AlanBateman an approved CSR request is already required for this pull request.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Jan 6, 2026
@openjdk
Copy link

openjdk bot commented Jan 6, 2026

@AlanBateman The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@AlanBateman AlanBateman marked this pull request as ready for review January 6, 2026 10:22
@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 6, 2026
@mlbridge
Copy link

mlbridge bot commented Jan 6, 2026

Webrevs

Copy link
Member

@jaikiran jaikiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

Comment on lines +1085 to +1087
* exception outcome is obtained, this method may not be invoked again. The only
* case where the method may be called again is where {@code InterruptedException}
* is thrown while waiting.
* case where this method may be called again by the scope owner is after
* {@code InterruptedException} is thrown.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just offering a potential alternative formulation.

This method must only be called once, unless the previous invocation resulted in an {@code InterruptedException} being thrown.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just offering a potential alternative formulation.

This method must only be called once, unless the previous invocation resulted in an {@code InterruptedException} being thrown.

Thanks, I'll see if I can incorporate some of this into the existing sentence.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks Alan!

@viktorklang-ora
Copy link
Contributor

I see @jaikiran is already on this, so I'll just chime in and say that it looks good from my perspective.

@openjdk openjdk bot removed the csr Pull request needs approved CSR before integration label Jan 7, 2026
@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 7, 2026
@AlanBateman
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Jan 7, 2026

Going to push as commit 6af2742.
Since your change was applied there have been 26 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 7, 2026
@openjdk openjdk bot closed this Jan 7, 2026
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 7, 2026
@openjdk
Copy link

openjdk bot commented Jan 7, 2026

@AlanBateman Pushed as commit 6af2742.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@AlanBateman
Copy link
Contributor Author

/backport :jdk26

@openjdk
Copy link

openjdk bot commented Jan 7, 2026

@AlanBateman the backport was successfully created on the branch backport-AlanBateman-6af27420-jdk26 in my personal fork of openjdk/jdk. To create a pull request with this backport targeting openjdk/jdk:jdk26, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 6af27420 from the openjdk/jdk repository.

The commit being backported was authored by Alan Bateman on 7 Jan 2026 and was reviewed by Jaikiran Pai.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk:

$ git fetch https://github.com/openjdk-bots/jdk.git backport-AlanBateman-6af27420-jdk26:backport-AlanBateman-6af27420-jdk26
$ git checkout backport-AlanBateman-6af27420-jdk26
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk.git backport-AlanBateman-6af27420-jdk26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants