8373427: StructuredTaskScope::join not clear if called with interrupted status set#29059
8373427: StructuredTaskScope::join not clear if called with interrupted status set#29059AlanBateman wants to merge 2 commits intoopenjdk:masterfrom
Conversation
|
/csr |
|
👋 Welcome back alanb! A progress list of the required criteria for merging this PR into |
|
@AlanBateman This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 22 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
@AlanBateman an approved CSR request is already required for this pull request. |
|
@AlanBateman The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
| * exception outcome is obtained, this method may not be invoked again. The only | ||
| * case where the method may be called again is where {@code InterruptedException} | ||
| * is thrown while waiting. | ||
| * case where this method may be called again by the scope owner is after | ||
| * {@code InterruptedException} is thrown. |
There was a problem hiding this comment.
Just offering a potential alternative formulation.
This method must only be called once, unless the previous invocation resulted in an {@code InterruptedException} being thrown.
There was a problem hiding this comment.
Just offering a potential alternative formulation.
This method must only be called once, unless the previous invocation resulted in an {@code InterruptedException} being thrown.
Thanks, I'll see if I can incorporate some of this into the existing sentence.
There was a problem hiding this comment.
Looks good, thanks Alan!
|
I see @jaikiran is already on this, so I'll just chime in and say that it looks good from my perspective. |
|
/integrate |
|
Going to push as commit 6af2742.
Your commit was automatically rebased without conflicts. |
|
@AlanBateman Pushed as commit 6af2742. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
|
/backport :jdk26 |
|
@AlanBateman the backport was successfully created on the branch backport-AlanBateman-6af27420-jdk26 in my personal fork of openjdk/jdk. To create a pull request with this backport targeting openjdk/jdk:jdk26, just click the following link: The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:
If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk: |
Small docs-only clarification to make it clearer that join throws InterruptedException if called with the current thread's interrupted status set. Also make it clear that the exception clears the interrupted status.
Progress
Issues
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/29059/head:pull/29059$ git checkout pull/29059Update a local copy of the PR:
$ git checkout pull/29059$ git pull https://git.openjdk.org/jdk.git pull/29059/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 29059View PR using the GUI difftool:
$ git pr show -t 29059Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/29059.diff
Using Webrev
Link to Webrev Comment