Skip to content

8374632: Broken list layout in the man page of jlink#29069

Closed
ammbra wants to merge 3 commits intoopenjdk:masterfrom
ammbra:8374632-broken-list-jlink-man
Closed

8374632: Broken list layout in the man page of jlink#29069
ammbra wants to merge 3 commits intoopenjdk:masterfrom
ammbra:8374632-broken-list-jlink-man

Conversation

@ammbra
Copy link
Contributor

@ammbra ammbra commented Jan 6, 2026

This PR contains an empty line to fix the formatting issue introduced in jlink's man page. I tested locally by building the JDK and the layout looks like in attachment.
image


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8374632: Broken list layout in the man page of jlink (Bug - P4)

Reviewers

Reviewers without OpenJDK IDs

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/29069/head:pull/29069
$ git checkout pull/29069

Update a local copy of the PR:
$ git checkout pull/29069
$ git pull https://git.openjdk.org/jdk.git pull/29069/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 29069

View PR using the GUI difftool:
$ git pr show -t 29069

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/29069.diff

Using Webrev

Link to Webrev Comment

Signed-off-by: Ana-Maria Mihalceanu <ana-maria.m.mihalceanu@oracle.com>
@ammbra ammbra changed the title Fix broken layout of markdown list inside jlink's man page. 8374632: Broken list layout in the man page of jlink Jan 6, 2026
@bridgekeeper
Copy link

bridgekeeper bot commented Jan 6, 2026

👋 Welcome back ammbra! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 6, 2026

@ammbra This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8374632: Broken list layout in the man page of jlink

Reviewed-by: jpai

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 29 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jaikiran) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Jan 6, 2026
@openjdk
Copy link

openjdk bot commented Jan 6, 2026

@ammbra The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 6, 2026
@mlbridge
Copy link

mlbridge bot commented Jan 6, 2026

Webrevs

@jaikiran
Copy link
Member

jaikiran commented Jan 7, 2026

Hello Ana, this looks OK to me. Can you please also update the copyright year on the top of this file from 2017, 2025, to 2017, 2026,?

Signed-off-by: Ana-Maria Mihalceanu <ana-maria.m.mihalceanu@oracle.com>
@openjdk
Copy link

openjdk bot commented Jan 7, 2026

⚠️ @ammbra the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout 8374632-broken-list-jlink-man
$ git commit --author='Preferred Full Name <you@example.com>' --allow-empty -m 'Update full name'
$ git push

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 7, 2026
@ammbra
Copy link
Contributor Author

ammbra commented Jan 7, 2026

/integrate

@ammbra
Copy link
Contributor Author

ammbra commented Jan 7, 2026

/backport :jdk26

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jan 7, 2026
@openjdk
Copy link

openjdk bot commented Jan 7, 2026

@ammbra
Your change (at version ab2c2e1) is now ready to be sponsored by a Committer.

@openjdk
Copy link

openjdk bot commented Jan 7, 2026

@ammbra To use the /backport command, you need to be in the OpenJDK census and your GitHub account needs to be linked with your OpenJDK username (how to associate your GitHub account with your OpenJDK username).

@jaikiran
Copy link
Member

jaikiran commented Jan 7, 2026

/sponsor

@openjdk
Copy link

openjdk bot commented Jan 7, 2026

Going to push as commit a01283a.
Since your change was applied there have been 29 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 7, 2026
@openjdk openjdk bot closed this Jan 7, 2026
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jan 7, 2026
@openjdk
Copy link

openjdk bot commented Jan 7, 2026

@jaikiran @ammbra Pushed as commit a01283a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants