8374662: Remove unused type check functions from javaClasses.hpp

[iklam]

Please review this trivial patch.

These functions are never used and should be removed.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8374662: Remove unused type check functions from javaClasses.hpp (Enhancement - P4)

Reviewers

• Johan Sjölen (@jdksjolen - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/29077/head:pull/29077
$ git checkout pull/29077

Update a local copy of the PR:
$ git checkout pull/29077
$ git pull https://git.openjdk.org/jdk.git pull/29077/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 29077

View PR using the GUI difftool:
$ git pr show -t 29077

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/29077.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back iklam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@iklam This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8374662: Remove unused type check functions from javaClasses.hpp

Reviewed-by: jsjolen

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

• da14813: 8373453: C2 SuperWord: must handle load slices that have loads with different memory inputs
• 929864b: 8362087: Test containers/docker/ShareTmpDir.java intermittent fails
• d7a3df6: 8374436: compiler/igvn/IntegerDivValueTests.java failed with division by zero
• ... and 7 more: https://git.openjdk.org/jdk/compare/6b3c1e0f786a889d2ac25c8bd05f4d83e666425f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@iklam The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (4efcfcac)
• 00: Full (bbf4858d)

[johan-sjolen]

OK and trivial, but: Were you able to track down where these were used previously?

[iklam]

OK and trivial, but: Were you able to track down where these were used previously?

NativeEntryPoint::is_instance() was first called from ciObjectFactory::create_new_object(oop o) in here:

https://github.com/openjdk/jdk/commit/0fb31dbf3a2adc0f7fb2f9924083908724dcde5a.diff

The call was removed from here, and the function became an orphan:

https://github.com/openjdk/jdk/commit/81e4bdbe1358b7feced08ba758ddb66415968036.diff

The second changeset also added ABIDescriptor::is_instance() but there were no callers. I think this was due to cut-and-paste.

[iklam]

Thanks @jdksjolen for the review
/integrate

[openjdk]

Going to push as commit 9513758.
Since your change was applied there have been 17 commits pushed to the master branch:

• 70669d0: 8374712: AOTMappedHeapWriter::relocate_field_in_buffer should use CompressedOops::narrow_oop_cast
• 0a1fa21: 8369150: NMethodRelocationTest fails when JVMTI events not published before JVM exit
• 9a944e5: 8372754: Add wrapper for
• ... and 14 more: https://git.openjdk.org/jdk/compare/6b3c1e0f786a889d2ac25c8bd05f4d83e666425f...master

Your commit was automatically rebased without conflicts.

[openjdk]

@iklam Pushed as commit 9513758.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.