8373448: jpackage: StackOverflowError when processing a very long argument

[alexeysemenyukoracle]

Replace reluctant quantifier *? with the possessive alternative (*+) and get rid of back-references from the regexp tokenizing a value of the "--arguments" option into a string array to fix the catastrophic backtracking resulting in a stack overflow.

Old regexp: (?:(?:(["'])(?:\\\1|.)*?(?:\1|$))|(?:\\["'\s]|[^\s]))++

New regexp (?:(?:(?:'(?:\\'|[^'])*+(?:'|$))|(?:"(?:\\"|[^"])*+(?:"|$)))|(?:\\["'\s]|\S))++

Add test cases that pass both the old and the new variants of the regexp, except for the last test case that causes a stack overflow with the old regexp.

The initial intention was to replace the regexp with the tokenizer function. It was abandoned in favor of reworking the regexp to minimize the risk of regressions.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8373448: jpackage: StackOverflowError when processing a very long argument (Bug - P3)

Reviewers

• Alexander Matveev (@sashamatveev - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/29104/head:pull/29104
$ git checkout pull/29104

Update a local copy of the PR:
$ git checkout pull/29104
$ git pull https://git.openjdk.org/jdk.git pull/29104/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 29104

View PR using the GUI difftool:
$ git pr show -t 29104

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/29104.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back asemenyuk! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@alexeysemenyukoracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8373448: jpackage: StackOverflowError when processing a very long argument

Reviewed-by: almatvee

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 70 new commits pushed to the master branch:

• 385c4f8: 8373714: Shenandoah: Register heuristic penalties following a degenerated GC
• 982aa3f: 8336654: [lworld] Tests depending on sun.awt.AppContext can fail when run with migrated classes
• 1342db0: 8374051: Incorrect parameterized testing of exceptions in AbstractDateTimeTest.java
• ... and 67 more: https://git.openjdk.org/jdk/compare/2daf12edd24e641d4d7706d582994c2b3fe95e87...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@alexeysemenyukoracle The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[alexeysemenyukoracle]

/issue add 8373448

[openjdk]

@alexeysemenyukoracle This issue is referenced in the PR title - it will now be updated.

[alexeysemenyukoracle]

@sashamatveev PTAL

[alexeysemenyukoracle]

@fguallini can you think of any inputs to stress test/break the new regexp?

[mlbridge]

Webrevs

• 01: Full - Incremental (d8ebb1dd)
• 00: Full (8210135a)

[sashamatveev]

Why we need to print old and new pattern? Looks like debug code was not removed.

[alexeysemenyukoracle]

Oh, the debug output slipped in.

[sashamatveev]

Looks good.

[fguallini]

@fguallini can you think of any inputs to stress test/break the new regexp?

LGTM, I can't think of any other cases that would cause an issue

[alexeysemenyukoracle]

/integrate

[openjdk]

Going to push as commit 8737a8c.
Since your change was applied there have been 80 commits pushed to the master branch:

• 6d1bfdf: 8374796: CompressedOops versions of runtime/cds/TestDefaultArchiveLoading.java aren't run
• 47e1935: 8373941: Epsilon: Robust counter updates in early VM phases
• c8c6e70: 8374825: vmTestbase comment typo: lunch
• ... and 77 more: https://git.openjdk.org/jdk/compare/2daf12edd24e641d4d7706d582994c2b3fe95e87...master

Your commit was automatically rebased without conflicts.

[openjdk]

@alexeysemenyukoracle Pushed as commit 8737a8c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.