Skip to content

8373832: Test java/lang/invoke/TestVHInvokerCaching.java tests nothing#29131

Closed
Shivangi-aa wants to merge 1 commit intoopenjdk:jdk26from
openjdk-bots:backport-Shivangi-aa-e75726ee-jdk26
Closed

8373832: Test java/lang/invoke/TestVHInvokerCaching.java tests nothing#29131
Shivangi-aa wants to merge 1 commit intoopenjdk:jdk26from
openjdk-bots:backport-Shivangi-aa-e75726ee-jdk26

Conversation

@Shivangi-aa
Copy link

@Shivangi-aa Shivangi-aa commented Jan 9, 2026

Hi all,

This pull request contains a backport of commit e75726ee from the openjdk/jdk repository.

The commit being backported was authored by Chen Liang on 17 Dec 2025 and was reviewed by Jorn Vernee and Aleksey Shipilev.

Thanks!

Straight Backport . The test is passing in JDk26 CI.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8373832: Test java/lang/invoke/TestVHInvokerCaching.java tests nothing (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/29131/head:pull/29131
$ git checkout pull/29131

Update a local copy of the PR:
$ git checkout pull/29131
$ git pull https://git.openjdk.org/jdk.git pull/29131/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 29131

View PR using the GUI difftool:
$ git pr show -t 29131

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/29131.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 9, 2026

👋 Welcome back sshivang! A progress list of the required criteria for merging this PR into jdk26 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 9, 2026

@Shivangi-aa This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8373832: Test java/lang/invoke/TestVHInvokerCaching.java tests nothing

Reviewed-by: liach

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the jdk26 branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@liach) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport e75726ee03ca4664827ca5d680c02bcf2a96f4ea 8373832: Test java/lang/invoke/TestVHInvokerCaching.java tests nothing Jan 9, 2026
@openjdk
Copy link

openjdk bot commented Jan 9, 2026

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required core-libs core-libs-dev@openjdk.org labels Jan 9, 2026
@openjdk
Copy link

openjdk bot commented Jan 9, 2026

@Shivangi-aa The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 9, 2026
@mlbridge
Copy link

mlbridge bot commented Jan 9, 2026

Webrevs

Copy link
Member

@liach liach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but should we update the license year?

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 9, 2026
@Shivangi-aa
Copy link
Author

@liach , it was updated in main MR so I retained the same.

@Shivangi-aa
Copy link
Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jan 9, 2026
@openjdk
Copy link

openjdk bot commented Jan 9, 2026

@Shivangi-aa
Your change (at version c6c6a79) is now ready to be sponsored by a Committer.

@Shivangi-aa
Copy link
Author

@liach Can you please sponsor this ?

@liach
Copy link
Member

liach commented Jan 9, 2026

Let's have a sustaining engineer to review before integration.

1 similar comment
@liach
Copy link
Member

liach commented Jan 9, 2026

Let's have a sustaining engineer to review before integration.

@Shivangi-aa
Copy link
Author

@liach Can you please tag someone for sustaining.

@liach
Copy link
Member

liach commented Jan 12, 2026

Guess I'll just sponsor.

/sponsor

1 similar comment
@liach
Copy link
Member

liach commented Jan 12, 2026

Guess I'll just sponsor.

/sponsor

@openjdk
Copy link

openjdk bot commented Jan 12, 2026

Going to push as commit 7317343.
Since your change was applied there have been 4 commits pushed to the jdk26 branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 12, 2026
@openjdk openjdk bot closed this Jan 12, 2026
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jan 12, 2026
@openjdk
Copy link

openjdk bot commented Jan 12, 2026

@liach @Shivangi-aa Pushed as commit 7317343.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@openjdk
Copy link

openjdk bot commented Jan 12, 2026

@liach The command sponsor can only be used in open pull requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants