8374922: Build failure after JDK-8372040#29148
8374922: Build failure after JDK-8372040#29148kimbarrett wants to merge 1 commit intoopenjdk:masterfrom
Conversation
|
👋 Welcome back kbarrett! A progress list of the required criteria for merging this PR into |
|
@kimbarrett This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
|
@kimbarrett The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
stuart-marks
left a comment
There was a problem hiding this comment.
Change looks good. I've verified with my local build that this change fixes the compilation error introduced by JDK-8372040.
|
Thanks for the quick review @stuart-marks |
|
/integrate |
|
@kimbarrett Pushed as commit 0537a3f. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Please review this trivial change to fix a build failure caused by a missing
#include.Testing: mach5 tier1
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/29148/head:pull/29148$ git checkout pull/29148Update a local copy of the PR:
$ git checkout pull/29148$ git pull https://git.openjdk.org/jdk.git pull/29148/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 29148View PR using the GUI difftool:
$ git pr show -t 29148Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/29148.diff
Using Webrev
Link to Webrev Comment