Skip to content

8374922: Build failure after JDK-8372040#29148

Closed
kimbarrett wants to merge 1 commit intoopenjdk:masterfrom
kimbarrett:prefetch-build-failure
Closed

8374922: Build failure after JDK-8372040#29148
kimbarrett wants to merge 1 commit intoopenjdk:masterfrom
kimbarrett:prefetch-build-failure

Conversation

@kimbarrett
Copy link

@kimbarrett kimbarrett commented Jan 10, 2026

Please review this trivial change to fix a build failure caused by a missing #include.

Testing: mach5 tier1


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8374922: Build failure after JDK-8372040 (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/29148/head:pull/29148
$ git checkout pull/29148

Update a local copy of the PR:
$ git checkout pull/29148
$ git pull https://git.openjdk.org/jdk.git pull/29148/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 29148

View PR using the GUI difftool:
$ git pr show -t 29148

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/29148.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 10, 2026

👋 Welcome back kbarrett! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 10, 2026

@kimbarrett This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8374922: Build failure after JDK-8372040

Reviewed-by: smarks

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • a726e83: 8373231: ECDSAOperations::toAffinePoint is redundant

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Jan 10, 2026
@openjdk
Copy link

openjdk bot commented Jan 10, 2026

@kimbarrett The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 10, 2026
Copy link
Member

@stuart-marks stuart-marks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good. I've verified with my local build that this change fixes the compilation error introduced by JDK-8372040.

@mlbridge
Copy link

mlbridge bot commented Jan 10, 2026

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 10, 2026
@kimbarrett
Copy link
Author

Thanks for the quick review @stuart-marks

@kimbarrett
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented Jan 10, 2026

Going to push as commit 0537a3f.
Since your change was applied there has been 1 commit pushed to the master branch:

  • a726e83: 8373231: ECDSAOperations::toAffinePoint is redundant

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 10, 2026
@openjdk openjdk bot closed this Jan 10, 2026
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 10, 2026
@openjdk
Copy link

openjdk bot commented Jan 10, 2026

@kimbarrett Pushed as commit 0537a3f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@kimbarrett kimbarrett deleted the prefetch-build-failure branch January 10, 2026 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants