Skip to content

8374181: failure_handler: The cores.html file is formatted incorrectly and so hides the core dump information#29150

Closed
jaikiran wants to merge 2 commits intoopenjdk:masterfrom
jaikiran:8374181
Closed

8374181: failure_handler: The cores.html file is formatted incorrectly and so hides the core dump information#29150
jaikiran wants to merge 2 commits intoopenjdk:masterfrom
jaikiran:8374181

Conversation

@jaikiran
Copy link
Member

@jaikiran jaikiran commented Jan 10, 2026 •
edited by openjdk bot
Loading

Can I please get a review of this jtreg failure handler code change which addresses the issue noted in https://bugs.openjdk.org/browse/JDK-8374181?

The implementation in this failure handler generates a cores.html for each core file that was generated during the test run. The bug here is that instead of creating multiple "sections", one each for the core file, within an <html> element, it ends up creating multiple <html> elements one after another within the same HTML file. This causes the HTML rendering to go wrong.

The commit in this PR addresses that issue by creating one section, under the <html> element, for each core file.

I've verified that with this change, the cores.html is now correctly structured and rendered.

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8374181: failure_handler: The cores.html file is formatted incorrectly and so hides the core dump information (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/29150/head:pull/29150
$ git checkout pull/29150

Update a local copy of the PR:
$ git checkout pull/29150
$ git pull https://git.openjdk.org/jdk.git pull/29150/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 29150

View PR using the GUI difftool:
$ git pr show -t 29150

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/29150.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 10, 2026

👋 Welcome back jpai! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 10, 2026 •
edited
Loading

@jaikiran This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8374181: failure_handler: The cores.html file is formatted incorrectly and so hides the core dump information

Reviewed-by: erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Jan 10, 2026
@openjdk
Copy link

openjdk bot commented Jan 10, 2026 •
edited
Loading

@jaikiran The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@jaikiran
Copy link
Member Author

jaikiran commented Jan 10, 2026

/label remove core-libs
/label add build

@openjdk openjdk bot added rfr Pull request is ready for review and removed core-libs core-libs-dev@openjdk.org labels Jan 10, 2026
@openjdk
Copy link

openjdk bot commented Jan 10, 2026

@jaikiran
The core-libs label was successfully removed.

@openjdk openjdk bot added build build-dev@openjdk.org and removed rfr Pull request is ready for review labels Jan 10, 2026
@openjdk
Copy link

openjdk bot commented Jan 10, 2026

@jaikiran
The build label was successfully added.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 10, 2026
@mlbridge
Copy link

mlbridge bot commented Jan 10, 2026 •
edited
Loading

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 12, 2026
@jaikiran
Copy link
Member Author

jaikiran commented Jan 13, 2026

Thank you Erik for the review.

@jaikiran
Copy link
Member Author

jaikiran commented Jan 13, 2026

/integrate

@openjdk
Copy link

openjdk bot commented Jan 13, 2026

Going to push as commit e89c129.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 15b7a42: 8373819: Genshen: Control thread can miss allocation failure notification (redux)
  • 9a2592f: 8374953: Add note on about implicit state when comparing TypeMirrors

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 13, 2026
@openjdk openjdk bot closed this Jan 13, 2026
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 13, 2026
@openjdk
Copy link

openjdk bot commented Jan 13, 2026

@jaikiran Pushed as commit e89c129.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@jaikiran jaikiran deleted the 8374181 branch January 13, 2026 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@erikj79 erikj79 erikj79 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

build build-dev@openjdk.org integrated Pull request has been integrated

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jaikiran @erikj79