8253447: Remove buggy code introduced by 8249451

[jamsheedcm]

if ((thread->has_pending_exception() || thread->frames_to_pop_failed_realloc() > 0) && exec_mode != Unpack_uncommon_trap) {
assert(thread->has_pending_exception(), "should have thrown OOME/Async");

introduced a buggy code checking, clearing pending exception and taking Unpack_exception route.

This can have consequences as the deopt entries may have additional logic depending on bci's. and the change introduced in 8249451 doesn't honor deopt exception checking and forward logic.
Thank you @fisk for pointing the bug in the code.
Request for review.

/cc hotspot-compiler
/cc hotspot-runtime

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8253447: Remove buggy code introduced by 8249451

Reviewers

• Igor Veresov (@veresov - Reviewer)
• Erik Österlund (@fisk - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/292/head:pull/292
$ git checkout pull/292

[bridgekeeper]

👋 Welcome back jcm! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@jamsheedcm
The hotspot-compiler label was successfully added.

[openjdk]

@jamsheedcm
The hotspot-runtime label was successfully added.

[openjdk]

@jamsheedcm The following label will be automatically applied to this pull request: hotspot.

When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label (add|remove) "label" command.

[mlbridge]

Webrevs

• 01: Full - Incremental (4eea9a9)
• 00: Full (d81ce18)

[jamsheedcm]

@dholmes-ora @veresov @fisk could you please have a look.

[openjdk]

@jamsheedcm This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements

After integration, the commit message will be:

8253447: Remove buggy code introduced by 8249451

Reviewed-by: iveresov, eosterlund

• If you would like to add a summary, use the /summary command.
• To credit additional contributors, use the /contributor command.
• To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 2 commits pushed to the master branch:

• 282b9dc: 8081833: Clean up JVMFlag getter/setter code
• 0e98fc1: 8253237: [REDO] Improve large object handling during evacuation

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 282b9dcfdc0adc8596abc4e758756e84d337b2f7.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[fisk]

Looks good, thanks for fixing this.

[jamsheedcm]

Thank you @dholmes-ora @veresov @fisk

/integrate

[openjdk]

@jamsheedcm Since your change was applied there have been 2 commits pushed to the master branch:

• 282b9dc: 8081833: Clean up JVMFlag getter/setter code
• 0e98fc1: 8253237: [REDO] Improve large object handling during evacuation

Your commit was automatically rebased without conflicts.

Pushed as commit f7b1ce4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.