Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8189198: Add "forRemoval = true" to Applet API deprecations #2920

Closed
wants to merge 301 commits into from

Conversation

@andyherrick
Copy link

@andyherrick andyherrick commented Mar 10, 2021

implementation of
JDK-8256145: JEP 398: Deprecate the Applet API for Removal


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8189198: Add "forRemoval = true" to Applet API deprecations

Reviewers

Download

To checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/2920/head:pull/2920
$ git checkout pull/2920

To update a local copy of the PR:
$ git checkout pull/2920
$ git pull https://git.openjdk.java.net/jdk pull/2920/head

@andyherrick
Copy link
Author

@andyherrick andyherrick commented Mar 10, 2021

/csr

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Mar 10, 2021

👋 Welcome back herrick! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the csr label Mar 10, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Mar 10, 2021

@andyherrick this pull request will not be integrated until the CSR request JDK-8189232 for issue JDK-8189198 has been approved.

@openjdk
Copy link

@openjdk openjdk bot commented Mar 10, 2021

@andyherrick The following labels will be automatically applied to this pull request:

  • 2d
  • awt
  • beans
  • core-libs
  • i18n
  • sound
  • swing

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@andyherrick andyherrick marked this pull request as ready for review Mar 12, 2021
@openjdk openjdk bot added the rfr label Mar 12, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Mar 12, 2021

Webrevs

@AlanBateman
Copy link
Contributor

@AlanBateman AlanBateman commented Mar 14, 2021

Have you looked at narrowing the use of the SuppressWarnings to local variable declarations to avoid adding it to some of these methods?

@andyherrick
Copy link
Author

@andyherrick andyherrick commented Mar 17, 2021

the

@andyherrick andyherrick reopened this Mar 17, 2021
@andyherrick
Copy link
Author

@andyherrick andyherrick commented Mar 17, 2021

Have you looked at narrowing the use of the SuppressWarnings to local variable declarations to avoid adding it to some of these methods?

in all cases either:

  • the class or method itself is being deprecated
  • the method takes a deprecated arg .
  • there is no local variable involved, such as testing if something is an instanceOf a class being deprecated, or calling a deprecated method.

I cannot find any instances where the scope can be narrowed

@AlanBateman
Copy link
Contributor

@AlanBateman AlanBateman commented Mar 17, 2021

I cannot find any instances where the scope can be narrowed

Are you about AquaInternalFrameUI.mouseRelased, BasicPopupMenuUI. stateChanged, and other non-trivial methods?

@andyherrick
Copy link
Author

@andyherrick andyherrick commented Mar 17, 2021

I cannot find any instances where the scope can be narrowed

Are you about AquaInternalFrameUI.mouseRelased, BasicPopupMenuUI. stateChanged, and other non-trivial methods?

These have the code pattern such as:
} else if (c instanceof JApplet) {
putting '@SuppressWarnings("removal")' before the declaration of 'c' does not help, because the code is not an assignment to 'c'

reinrich and others added 16 commits Mar 25, 2021
….trim()

Reviewed-by: serb, pbansal, kizune, trebari, psadhukhan
…contains plaform specific parameters

Reviewed-by: herrick, dcubed
8253816: Support macOS W^X
8253817: Support macOS Aarch64 ABI in Interpreter
8253818: Support macOS Aarch64 ABI for compiled wrappers
8253819: Implement os/cpu for macOS/AArch64
8253839: Update tests and JDK code for macOS/Aarch64
8254941: Implement Serviceability Agent for macOS/AArch64
8255776: Change build system for macOS/AArch64
8262903: [macos_aarch64] Thread::current() called on detached thread

Co-authored-by: Vladimir Kempik <vkempik@openjdk.org>
Co-authored-by: Bernhard Urban-Forster <burban@openjdk.org>
Co-authored-by: Ludovic Henry <luhenry@openjdk.org>
Co-authored-by: Monica Beckwith <mbeckwit@openjdk.org>
Reviewed-by: erikj, ihse, prr, cjplummer, stefank, gziemski, aph, mbeckwit, luhenry
…eadfilter001/TestDescription.java failed with "ERROR: eventSet1.size() != 3 :: 2"

Reviewed-by: cjplummer, lmesnik, sspitsyn
@andyherrick
Copy link
Author

@andyherrick andyherrick commented Mar 25, 2021

pushed minor change to src/java.desktop/share/classes/java/applet/package-info.java as well as merge with master.

Copy link
Member

@kevinrushforth kevinrushforth left a comment

Looks good.

@prrace
prrace approved these changes Mar 25, 2021
@openjdk openjdk bot removed the csr label Mar 26, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Mar 26, 2021

@andyherrick This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8189198: Add "forRemoval = true" to Applet API deprecations

Reviewed-by: iris, almatvee, kcr, prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • fe8ef32: 8264151: ciMethod::ensure_method_data() should return false is loading resulted in empty state

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Mar 26, 2021
@andyherrick
Copy link
Author

@andyherrick andyherrick commented Mar 26, 2021

/integrate

@openjdk openjdk bot closed this Mar 26, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Mar 26, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Mar 26, 2021

@andyherrick Since your change was applied there have been 9 commits pushed to the master branch:

  • b8122d6: 8264220: jdk/javadoc/doclet/testRelatedPackages/TestRelatedPackages.java fails to compile
  • 507b690: 8264126: Remove TRAPS/THREAD parameter for class loading functions
  • f3eed05: 8263928: Add JAWT test files for mac
  • 4fbb7c2: 8263472: Specification of JComponent::updateUI should document that the default implementation does nothing
  • e47dfb8: 8264062: Use the blessed modifier order in jdk.jfr
  • 5a930c4: 8264135: UnsafeGetStableArrayElement should account for different JIT implementation details
  • bb354b9: 8264166: OopStorage should support specifying MEMFLAGS for allocations
  • 41657b1: 8261551: Remove special CDS handling in Metaspace::allocate
  • fe8ef32: 8264151: ciMethod::ensure_method_data() should return false is loading resulted in empty state

Your commit was automatically rebased without conflicts.

Pushed as commit 57115fa.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@andyherrick andyherrick deleted the andyherrick:8189198 branch Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment