8189198: Add "forRemoval = true" to Applet API deprecations

[andyherrick]

implementation of
JDK-8256145: JEP 398: Deprecate the Applet API for Removal

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8189198: Add "forRemoval = true" to Applet API deprecations

Reviewers

• Iris Clark (@irisclark - Reviewer)
• Alexander Matveev (@sashamatveev - Committer) ⚠️ Review applies to 1148f20
• Kevin Rushforth (@kevinrushforth - Author)
• Phil Race (@prrace - Reviewer)

Download

To checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/2920/head:pull/2920
$ git checkout pull/2920

To update a local copy of the PR:
$ git checkout pull/2920
$ git pull https://git.openjdk.java.net/jdk pull/2920/head

[andyherrick]

/csr

[bridgekeeper]

👋 Welcome back herrick! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@andyherrick this pull request will not be integrated until the CSR request JDK-8189232 for issue JDK-8189198 has been approved.

[openjdk]

@andyherrick The following labels will be automatically applied to this pull request:

• 2d
• awt
• beans
• core-libs
• i18n
• sound
• swing

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (026f09c)
• 00: Full (1148f20)

[AlanBateman]

Have you looked at narrowing the use of the SuppressWarnings to local variable declarations to avoid adding it to some of these methods?

[andyherrick]

the

[andyherrick]

Have you looked at narrowing the use of the SuppressWarnings to local variable declarations to avoid adding it to some of these methods?

in all cases either:

• the class or method itself is being deprecated
• the method takes a deprecated arg .
• there is no local variable involved, such as testing if something is an instanceOf a class being deprecated, or calling a deprecated method.

I cannot find any instances where the scope can be narrowed

[AlanBateman]

I cannot find any instances where the scope can be narrowed

Are you about AquaInternalFrameUI.mouseRelased, BasicPopupMenuUI. stateChanged, and other non-trivial methods?

[andyherrick]

I cannot find any instances where the scope can be narrowed

Are you about AquaInternalFrameUI.mouseRelased, BasicPopupMenuUI. stateChanged, and other non-trivial methods?

These have the code pattern such as:
} else if (c instanceof JApplet) {
putting '@SuppressWarnings("removal")' before the declaration of 'c' does not help, because the code is not an assignment to 'c'

[andyherrick]

pushed minor change to src/java.desktop/share/classes/java/applet/package-info.java as well as merge with master.

[kevinrushforth]

Looks good.

[openjdk]

@andyherrick This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8189198: Add "forRemoval = true" to Applet API deprecations

Reviewed-by: iris, almatvee, kcr, prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

• fe8ef32: 8264151: ciMethod::ensure_method_data() should return false is loading resulted in empty state

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[andyherrick]

/integrate

[openjdk]

@andyherrick Since your change was applied there have been 9 commits pushed to the master branch:

• b8122d6: 8264220: jdk/javadoc/doclet/testRelatedPackages/TestRelatedPackages.java fails to compile
• 507b690: 8264126: Remove TRAPS/THREAD parameter for class loading functions
• f3eed05: 8263928: Add JAWT test files for mac
• 4fbb7c2: 8263472: Specification of JComponent::updateUI should document that the default implementation does nothing
• e47dfb8: 8264062: Use the blessed modifier order in jdk.jfr
• 5a930c4: 8264135: UnsafeGetStableArrayElement should account for different JIT implementation details
• bb354b9: 8264166: OopStorage should support specifying MEMFLAGS for allocations
• 41657b1: 8261551: Remove special CDS handling in Metaspace::allocate
• fe8ef32: 8264151: ciMethod::ensure_method_data() should return false is loading resulted in empty state

Your commit was automatically rebased without conflicts.

Pushed as commit 57115fa.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.