-
Notifications
You must be signed in to change notification settings - Fork 6k
8252833: Correct "no comment" warnings from javadoc in java.smartcardio module #2930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back wetmore! A progress list of the required criteria for merging this PR into |
@bradfordwetmore The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
/label security |
@bradfordwetmore |
@bradfordwetmore This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 4 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
... however, this fix does not achieve what the bug report is asking for. The patch here will modify flags to javac. The JBS issue talks about flags for javadoc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revoking approval.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please assign a new bug and title to ignore/suppress the warnings.
The original issue 8252833 should be left open.
Thanks
Closing, as it's unclear which approach should be taken. |
Disable the "missing" target for java.smartcardio from doclint.
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/2930/head:pull/2930
$ git checkout pull/2930