Skip to content

8252833: Correct "no comment" warnings from javadoc in java.smartcardio module #2930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

bradfordwetmore
Copy link
Contributor

@bradfordwetmore bradfordwetmore commented Mar 11, 2021

Disable the "missing" target for java.smartcardio from doclint.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8252833: Correct "no comment" warnings from javadoc in java.smartcardio module

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2930/head:pull/2930
$ git checkout pull/2930

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 11, 2021

👋 Welcome back wetmore! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 11, 2021

@bradfordwetmore The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the build build-dev@openjdk.org label Mar 11, 2021
@bradfordwetmore bradfordwetmore marked this pull request as ready for review March 11, 2021 01:16
@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 11, 2021
@bradfordwetmore
Copy link
Contributor Author

/label security

@openjdk openjdk bot added the security security-dev@openjdk.org label Mar 11, 2021
@openjdk
Copy link

openjdk bot commented Mar 11, 2021

@bradfordwetmore
The security label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Mar 11, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented Mar 11, 2021

@bradfordwetmore This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8252833: Correct "no comment" warnings from javadoc in java.smartcardio module

Reviewed-by: iris

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • a9b4f03: 8263069: Exclude some failing tests from security/infra/java/security/cert/CertPathValidator
  • 470b150: 8143041: Unify G1CollectorPolicy::PauseKind and G1YCType
  • f6b4ba0: 8261931: IGV: quick search fails on multi-line node labels
  • 7988c1d: 8262443: GenerateOopMap::do_interpretation can spin for a long time.

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 11, 2021
Copy link
Member

@magicus magicus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@magicus
Copy link
Member

magicus commented Mar 11, 2021

... however, this fix does not achieve what the bug report is asking for.

The patch here will modify flags to javac. The JBS issue talks about flags for javadoc.

Copy link
Member

@magicus magicus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revoking approval.

Copy link
Contributor

@RogerRiggs RogerRiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please assign a new bug and title to ignore/suppress the warnings.
The original issue 8252833 should be left open.
Thanks

@bradfordwetmore
Copy link
Contributor Author

Closing, as it's unclear which approach should be taken.

@bradfordwetmore bradfordwetmore deleted the JDK-8252833 branch March 18, 2021 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build build-dev@openjdk.org ready Pull request is ready to be integrated rfr Pull request is ready for review security security-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

4 participants