New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8263465: JDK-8236847 causes tier1 build failure on linux-aarch64 #2946
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@yminqi This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
This change can be integrated until the trivial fix rules.
Thanks to @iklam @erikj79 @dcubed-ojdk ! |
/integrate |
Mailing list message from Magnus Ihse Bursie on build-dev: Hi Yumin, While this fix corrected the actual problem, the end result is that the Instead of AC_MSG_CHECKING([if CDS region alignment is available]) Can you please /Magnus On 2021-03-11 20:00, Yumin Qi wrote: |
Got it, will do next. Thanks. |
Hi, Please review
JDK-8236847 changes failed on build linux-aarch64 on xcross build. The reason is we check BUILD_CDS_ARCHIVE which is not correct in such case. We should check ENABLE_CDS instead.
Thanks
Yumin
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/2946/head:pull/2946
$ git checkout pull/2946