Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8263465: JDK-8236847 causes tier1 build failure on linux-aarch64 #2946

Closed
wants to merge 1 commit into from

Conversation

@yminqi
Copy link
Contributor

@yminqi yminqi commented Mar 11, 2021

Hi, Please review

JDK-8236847 changes failed on build linux-aarch64 on xcross build. The reason is we check BUILD_CDS_ARCHIVE which is not correct in such case. We should check ENABLE_CDS instead.

Thanks
Yumin


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8263465: JDK-8236847 causes tier1 build failure on linux-aarch64

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2946/head:pull/2946
$ git checkout pull/2946

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Mar 11, 2021

👋 Welcome back minqi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Mar 11, 2021
iklam
iklam approved these changes Mar 11, 2021
Copy link
Member

@iklam iklam left a comment

LGTM

@openjdk
Copy link

@openjdk openjdk bot commented Mar 11, 2021

@yminqi The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the build label Mar 11, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Mar 11, 2021

@yminqi This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8263465: JDK-8236847 causes tier1 build failure on linux-aarch64

Reviewed-by: iklam, erikj, dcubed

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Mar 11, 2021
Copy link
Member

@dcubed-ojdk dcubed-ojdk left a comment

Looks good to me.
This change can be integrated until the trivial fix rules.

@yminqi
Copy link
Contributor Author

@yminqi yminqi commented Mar 11, 2021

@mlbridge
Copy link

@mlbridge mlbridge bot commented Mar 11, 2021

Webrevs

@yminqi
Copy link
Contributor Author

@yminqi yminqi commented Mar 11, 2021

/integrate

@openjdk openjdk bot closed this Mar 11, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Mar 11, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Mar 11, 2021

@yminqi Pushed as commit 15dacca.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@yminqi yminqi deleted the jdk-8263465 branch Mar 11, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Mar 12, 2021

Mailing list message from Magnus Ihse Bursie on build-dev:

Hi Yumin,

While this fix corrected the actual problem, the end result is that the
checking message went from slightly misleading to outright wrong.

Instead of
AC_MSG_CHECKING([if CDS archive is available]) it should read like this:

AC_MSG_CHECKING([if CDS region alignment is available]) Can you please
fix this in a follow-up bug? (And while you are at it, please change
"cds" to "CDS" in the other messages; we are using the capitalized
version of this acronym everywhere else in messages directed to the user.)

/Magnus

On 2021-03-11 20:00, Yumin Qi wrote:

@yminqi
Copy link
Contributor Author

@yminqi yminqi commented Mar 12, 2021

Mailing list message from Magnus Ihse Bursie on build-dev:

Hi Yumin,

While this fix corrected the actual problem, the end result is that the
checking message went from slightly misleading to outright wrong.

Instead of
AC_MSG_CHECKING([if CDS archive is available]) it should read like this:

AC_MSG_CHECKING([if CDS region alignment is available]) Can you please
fix this in a follow-up bug? (And while you are at it, please change
"cds" to "CDS" in the other messages; we are using the capitalized
version of this acronym everywhere else in messages directed to the user.)

/Magnus

On 2021-03-11 20:00, Yumin Qi wrote:

Got it, will do next. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants