8263465: JDK-8236847 causes tier1 build failure on linux-aarch64

[yminqi]

Hi, Please review

JDK-8236847 changes failed on build linux-aarch64 on xcross build. The reason is we check BUILD_CDS_ARCHIVE which is not correct in such case. We should check ENABLE_CDS instead.

Thanks
Yumin

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8263465: JDK-8236847 causes tier1 build failure on linux-aarch64

Reviewers

• Ioi Lam (@iklam - Reviewer)
• Erik Joelsson (@erikj79 - Reviewer)
• Daniel D. Daugherty (@dcubed-ojdk - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2946/head:pull/2946
$ git checkout pull/2946

[bridgekeeper]

👋 Welcome back minqi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[iklam]

LGTM

[openjdk]

@yminqi The following label will be automatically applied to this pull request:

• build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[openjdk]

@yminqi This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8263465: JDK-8236847 causes tier1 build failure on linux-aarch64

Reviewed-by: iklam, erikj, dcubed

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[dcubed-ojdk]

Looks good to me.
This change can be integrated until the trivial fix rules.

[yminqi]

Thanks to @iklam @erikj79 @dcubed-ojdk !

[mlbridge]

Webrevs

• 00: Full (6536586)

[yminqi]

/integrate

[openjdk]

@yminqi Pushed as commit 15dacca.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[mlbridge]

Mailing list message from Magnus Ihse Bursie on build-dev:

Hi Yumin,

While this fix corrected the actual problem, the end result is that the
checking message went from slightly misleading to outright wrong.

Instead of
AC_MSG_CHECKING([if CDS archive is available]) it should read like this:

AC_MSG_CHECKING([if CDS region alignment is available]) Can you please
fix this in a follow-up bug? (And while you are at it, please change
"cds" to "CDS" in the other messages; we are using the capitalized
version of this acronym everywhere else in messages directed to the user.)

/Magnus

On 2021-03-11 20:00, Yumin Qi wrote:

[yminqi]

Mailing list message from Magnus Ihse Bursie on build-dev:

Hi Yumin,

While this fix corrected the actual problem, the end result is that the
checking message went from slightly misleading to outright wrong.

Instead of
AC_MSG_CHECKING([if CDS archive is available]) it should read like this:

AC_MSG_CHECKING([if CDS region alignment is available]) Can you please
fix this in a follow-up bug? (And while you are at it, please change
"cds" to "CDS" in the other messages; we are using the capitalized
version of this acronym everywhere else in messages directed to the user.)

/Magnus

On 2021-03-11 20:00, Yumin Qi wrote:

Got it, will do next. Thanks.