-
Notifications
You must be signed in to change notification settings - Fork 5.8k
8263392: Allow current thread to be specified in ExceptionMark #2950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back iklam! A progress list of the required criteria for merging this PR into |
/label remove serviceability |
@iklam |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks for doing this cleanup.
David
@iklam This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. It would be nice to replace more EXCEPTION_MARK as we find them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is good.
Thanks @dholmes-ora @calvinccheung @coleenp @yminqi for the review. |
@iklam Since your change was applied there have been 2 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 1e57087. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
ExceptionMark
, usually used via theEXCEPTION_MARK
marco, is used to guarantee that an exception is not thrown within a block of code. I made two changes to improve efficiency:Thread::current()
if a thread object is already available.ExceptionMark
constructor. This helps C++ generate slightly better code.This new variant of
ExceptionMark
is mainly intended for future clean up ofTRAPS/CHECK/THREAD
code, where an exception context is temporarily needed but we will guarantee that all exceptions will be handled. I modifiedSharedRuntime::monitor_exit_helper()
to use this pattern:Old style:
New style:
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/2950/head:pull/2950
$ git checkout pull/2950