/ jdk Public
8263514: Minor issue in JavacFileManager.SortFiles.REVERSE #2970
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge.
SonarCloud reports the problem in JavacFileManager.SortFiles.REVERSE definition:
Neither "Math.abs" nor negation should be used on numbers that could be "MIN_VALUE"
compareTocan technically return
MIN_VALUE, we cannot simply negate it. Luckily, we can just swap the
f2comparison order to achieve the same effect without exposing us to this corner case.
$ git fetch https://git.openjdk.java.net/jdk pull/2970/head:pull/2970
$ git checkout pull/2970