Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8263477: serviceability/sa/ClhsdbDumpheap.java timed out #2981

Closed
wants to merge 1 commit into from

Conversation

@plummercj
Copy link
Contributor

@plummercj plummercj commented Mar 12, 2021

JDK-8257234 added a lot more subtests to this test, so now it sometimes times out. I've double the amount of time given to 240. I'd like to push this as a trivial change.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8263477: serviceability/sa/ClhsdbDumpheap.java timed out

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2981/head:pull/2981
$ git checkout pull/2981

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Mar 12, 2021

👋 Welcome back cjplummer! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Mar 12, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Mar 12, 2021

@plummercj The following label will be automatically applied to this pull request:

  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Mar 12, 2021

Webrevs

Copy link
Member

@dcubed-ojdk dcubed-ojdk left a comment

Thumbs up!

I agree that this is a trivial change.

@openjdk
Copy link

@openjdk openjdk bot commented Mar 13, 2021

@plummercj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8263477: serviceability/sa/ClhsdbDumpheap.java timed out

Reviewed-by: lmesnik, dcubed

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 43524cc: 8243455: Many SA tests can fail due to trying to get the stack trace of an active method

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Mar 13, 2021
@plummercj
Copy link
Contributor Author

@plummercj plummercj commented Mar 13, 2021

Thanks, Dan and Leonid!

@plummercj
Copy link
Contributor Author

@plummercj plummercj commented Mar 13, 2021

/integrate

@openjdk openjdk bot closed this Mar 13, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Mar 13, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Mar 13, 2021

@plummercj Since your change was applied there have been 6 commits pushed to the master branch:

  • a7aba2b: 8263549: 8263412 can cause jtreg testlibrary split
  • d339320: 8263136: C4530 was reported from VS 2019 at access bridge
  • a528771: 8262491: AArch64: CPU description should contain compatible board list
  • 86e4c75: 8256156: JFR: Allow 'jfr' tool to show metadata without a recording
  • 0b68ced: 8263548: runtime/cds/appcds/SharedRegionAlignmentTest.java fails to compile after JDK-8263412
  • 43524cc: 8243455: Many SA tests can fail due to trying to get the stack trace of an active method

Your commit was automatically rebased without conflicts.

Pushed as commit 8e562d2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@plummercj plummercj deleted the 8263477-ClhsdbDumheap branch Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants