8263549: 8263412 can cause jtreg testlibrary split

[iignatev]

Hi all,

could you please review this dull patch that replaces ClassFileInstaller w/ jdk.test.lib.helpers.ClassFileInstaller in all jtreg test descriptions to ensure we won't get split testlibrary, and removes jdk/test/lib/ClassFileInstaller.java (so it won't be accidentally used).

from JBS:

after JDK-8263412, we might (again) encounter NCDFE b/c parts of testlibraries aren't on the classpath. this happens when jtreg builds jdk.test.lib.helpers.ClassFileInstaller as a part of test-specific code, but ClassFileInstaller as part of shared testibrary directory in one test, when in the following test, jtreg sees ClassFileInstaller in the shared directory, hence javac won't recompile it/its dependencies, but in runtime jdk.test.lib.helpers.ClassFileInstaller is nowhere to be found, hence we get NCDFE.

testing:

• grep ' ClassFileInstaller[^.]
• tier1-3

Thanks,
-- Igor

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8263549: 8263412 can cause jtreg testlibrary split

Reviewers

• Ioi Lam (@iklam - Reviewer) ⚠️ Review applies to 6e53ad9
• Daniel D. Daugherty (@dcubed-ojdk - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2985/head:pull/2985
$ git checkout pull/2985

[bridgekeeper]

👋 Welcome back iignatyev! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@iignatev The following labels will be automatically applied to this pull request:

• core-libs
• hotspot
• security
• serviceability
• shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (3a3b7a8)
• 01: Full - Incremental (ff6d4f914bdfa1c77e264acd67b2af250f090ed9)
• 00: Full (6e53ad9)

[iignatev]

note for reviewers: the big part of the patch is just sed -i 's/ ClassFileInstaller / jdk.test.lib.helpers.ClassFileInstaller /g'

[iklam]

I did this and scanned the differences (with the diff file from the webrev) and it looks reasonable to me.

grep '^[+-]' diff.txt | grep -v Copyright | grep -v '^.[+-]' | less

It looks like most of the changes are mechanical. There were only a few cases where manual changes were made. I trusted that you have tested those cases individually.

But I don't understand why this error can happen. It seems like jtreg would allow two test cases to interfere with each other.

[openjdk]

@iignatev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8263549: 8263412 can cause jtreg testlibrary split

Reviewed-by: iklam, dcubed

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

• d339320: 8263136: C4530 was reported from VS 2019 at access bridge
• a528771: 8262491: AArch64: CPU description should contain compatible board list
• 86e4c75: 8256156: JFR: Allow 'jfr' tool to show metadata without a recording
• 0b68ced: 8263548: runtime/cds/appcds/SharedRegionAlignmentTest.java fails to compile after JDK-8263412

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[iignatev]

Hi Ioi,

thanks for review this, I ran the whole tier1-3 jobs which should provide enough coverage. as oracle builds don't have AOT feature enabled, I missed a compilation error in IncorrectAOTLibraryTest test. the test failed in GitHub action and should be fixed by 3a3b7a8.

-- Igor

[iklam]

But I don't understand why this error can happen. It seems like jtreg would allow two test cases to interfere with each other.

The root cause seems to be https://bugs.openjdk.java.net/browse/CODETOOLS-7902847

[dcubed-ojdk]

I downloaded the patch and used Ioi's cmd pattern to scroll through
the changes. I can't honestly say that I looked at every line since 867
changed files would overwhelm anyone's brain...

I did notice a couple of @run main instead of @run driver calls
to the ClassFileInstaller, but those are pre-existing.

Thumbs up.

[iignatev]

Hi Dan,

Thanks for your review!

I did notice a couple of @run main instead of @run driver calls to the ClassFileInstaller, but those are pre-existing.

I noticed this too, planning to fix that with a separate RFE.

-- Igor

[iignatev]

/integrate

[openjdk]

@iignatev Since your change was applied there have been 4 commits pushed to the master branch:

• d339320: 8263136: C4530 was reported from VS 2019 at access bridge
• a528771: 8262491: AArch64: CPU description should contain compatible board list
• 86e4c75: 8256156: JFR: Allow 'jfr' tool to show metadata without a recording
• 0b68ced: 8263548: runtime/cds/appcds/SharedRegionAlignmentTest.java fails to compile after JDK-8263412

Your commit was automatically rebased without conflicts.

Pushed as commit a7aba2b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.