Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8263154: [macos] DMG builds have finder errors #2987

Closed
wants to merge 1 commit into from

Conversation

@andyherrick
Copy link

@andyherrick andyherrick commented Mar 13, 2021


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2987/head:pull/2987
$ git checkout pull/2987

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Mar 13, 2021

👋 Welcome back herrick! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Mar 13, 2021

@andyherrick The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Mar 13, 2021

Webrevs

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Mar 14, 2021

Mailing list message from Michael Hall on core-libs-dev:

Thanks

Loading

@sashamatveev
Copy link
Member

@sashamatveev sashamatveev commented Mar 15, 2021

Can you explain what problem is and how it is fixed? Does it fails when "install-dir" is specified? "install-dir" is not relevant for DMG image and we should ignore it.

Loading

@andyherrick
Copy link
Author

@andyherrick andyherrick commented Mar 16, 2021

Can you explain what problem is and how it is fixed? Does it fails when "install-dir" is specified? "install-dir" is not relevant for DMG image and we should ignore it.

1.) The problem is, at least on Catalina, when in AppleScript you tell Finder to:
'make new alias file at POSIX file <payload path> to POSIX file <install dir> with properties {name:"<label to use>"}'
if <install dir> and <label to use> are the same string, it fails
result is you don't see the folder icon to drag payload into.

This is where "install dir" does mater on DMG. It is the folder the AppleScript will show in finder to suggest user to drag payload to. By default this is "/Applications" but behavior is exactly the same if I set it to, for example, "~/LocalApplications".
The fix only removes the leading slash from the label, so the folder will be labeled either "Applications" or (in my example) "Users/aherrick/LocalApplications".

Loading

@andyherrick andyherrick marked this pull request as draft Mar 16, 2021
@openjdk openjdk bot removed the rfr label Mar 16, 2021
@andyherrick andyherrick deleted the JDK-8263154 branch Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants