Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8263555: use driver-mode to run ClassFileInstaller #2989

Closed
wants to merge 1 commit into from

Conversation

iignatev
Copy link
Member

@iignatev iignatev commented Mar 13, 2021

Hi all,

could you please review this small and trivial clean-up patch that replaces @run main j.t.l.h.ClassFileInstaller w/ @run driver j.t.l.h.ClassFileInstaller?

from JBS:

there is no point in running ClassFileInstaller class w/ external flags, so it should be run w/ @run driver.

Thanks,
-- Igor


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8263555: use driver-mode to run ClassFileInstaller

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2989/head:pull/2989
$ git checkout pull/2989

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 13, 2021

👋 Welcome back iignatyev! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8263555 8263555: use driver-mode to run ClassFileInstaller Mar 13, 2021
@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 13, 2021
@openjdk
Copy link

openjdk bot commented Mar 13, 2021

@iignatev The following labels will be automatically applied to this pull request:

  • hotspot-gc
  • shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added hotspot-gc hotspot-gc-dev@openjdk.org shenandoah shenandoah-dev@openjdk.org labels Mar 13, 2021
@mlbridge
Copy link

mlbridge bot commented Mar 13, 2021

Webrevs

@iignatev
Copy link
Member Author

/label add hotspot

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Mar 13, 2021
@openjdk
Copy link

openjdk bot commented Mar 13, 2021

@iignatev
The hotspot label was successfully added.

Copy link
Member

@iklam iklam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and trivial.

@openjdk
Copy link

openjdk bot commented Mar 14, 2021

@iignatev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8263555: use driver-mode to run ClassFileInstaller

Reviewed-by: iklam

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 8e562d2: 8263477: serviceability/sa/ClhsdbDumpheap.java timed out

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 14, 2021
@iignatev
Copy link
Member Author

thanks, Ioi!

/integrate

@openjdk openjdk bot closed this Mar 14, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 14, 2021
@openjdk
Copy link

openjdk bot commented Mar 14, 2021

@iignatev Since your change was applied there has been 1 commit pushed to the master branch:

  • 8e562d2: 8263477: serviceability/sa/ClhsdbDumpheap.java timed out

Your commit was automatically rebased without conflicts.

Pushed as commit 9c84899.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@iignatev iignatev deleted the 8263555 branch March 14, 2021 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot hotspot-dev@openjdk.org hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated shenandoah shenandoah-dev@openjdk.org
2 participants