Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8263556: remove @modules java.base from tests #2990

Closed
wants to merge 2 commits into from

Conversation

iignatev
Copy link
Member

@iignatev iignatev commented Mar 13, 2021

Hi all,

could you please review this trivial cleanup?
from JBS:

jtreg @modules X directive does two things:

  • exclude a test from execution if JDK under test doesn't have module X
  • if JDK under test has module X, make sure it's resolved

both these things have no sense for java.base module as it's always available and is always resolved.

Thanks,
-- Igor


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2990/head:pull/2990
$ git checkout pull/2990

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Mar 13, 2021

👋 Welcome back iignatyev! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8263556 8263556: remove @modules java.base from tests Mar 13, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Mar 13, 2021

@iignatev The following labels will be automatically applied to this pull request:

  • core-libs
  • hotspot
  • i18n
  • shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added hotspot core-libs i18n shenandoah labels Mar 13, 2021
@iignatev
Copy link
Member Author

@iignatev iignatev commented Mar 15, 2021

/label add hotspot-gc hotspot-runtime

@openjdk openjdk bot added hotspot-gc hotspot-runtime labels Mar 15, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Mar 15, 2021

@iignatev
The hotspot-gc label was successfully added.

The hotspot-runtime label was successfully added.

@iignatev iignatev marked this pull request as ready for review Mar 15, 2021
@openjdk openjdk bot added the rfr label Mar 15, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Mar 15, 2021

Webrevs

Copy link
Member

@dcubed-ojdk dcubed-ojdk left a comment

Thumbs up.

I agree that this is a trivial change.

@openjdk
Copy link

@openjdk openjdk bot commented Mar 15, 2021

@iignatev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8263556: remove `@modules java.base` from tests

Reviewed-by: dcubed, naoto, iris

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 12 new commits pushed to the master branch:

  • d6b5e18: 8263191: Consolidate ThreadInVMfromJavaNoAsyncException and ThreadBlockInVMWithDeadlockCheck with existing wrappers
  • 80cdf78: 8263544: Unused argument in ConstantPoolCacheEntry::set_field()
  • c0176c4: 8263552: Use String.valueOf() for char-to-String conversions
  • fac39fe: 8263508: Remove dead code in MethodHandleImpl
  • 7b4aefe: 8263530: sun.awt.X11.ListHelper.removeAll() should use clear()
  • 32c7fcc: 8263490: [macos] Crash occurs on JPasswordField with activated InputMethod
  • 8afec70: 8260931: Implement JEP 382: New macOS Rendering Pipeline
  • 0638303: 8263497: Clean up sun.security.krb5.PrincipalName::toByteArray
  • ba22e6f: 8263446: Avoid unary minus over unsigned type in ObjectSynchronizer::dec_in_use_list_ceiling
  • b371f90: 8263504: Some OutputMachOpcodes fields are uninitialized
  • ... and 2 more: https://git.openjdk.java.net/jdk/compare/da9ead5e7fec1facdb4e44fc0a5b872edb704b9a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Mar 15, 2021
naotoj
naotoj approved these changes Mar 15, 2021
@iignatev
Copy link
Member Author

@iignatev iignatev commented Mar 15, 2021

Iris, Naoto, Dan, thank you for your reviews!

-- Igor

/integrate

@openjdk openjdk bot closed this Mar 15, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Mar 15, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Mar 15, 2021

@iignatev Since your change was applied there have been 12 commits pushed to the master branch:

  • d6b5e18: 8263191: Consolidate ThreadInVMfromJavaNoAsyncException and ThreadBlockInVMWithDeadlockCheck with existing wrappers
  • 80cdf78: 8263544: Unused argument in ConstantPoolCacheEntry::set_field()
  • c0176c4: 8263552: Use String.valueOf() for char-to-String conversions
  • fac39fe: 8263508: Remove dead code in MethodHandleImpl
  • 7b4aefe: 8263530: sun.awt.X11.ListHelper.removeAll() should use clear()
  • 32c7fcc: 8263490: [macos] Crash occurs on JPasswordField with activated InputMethod
  • 8afec70: 8260931: Implement JEP 382: New macOS Rendering Pipeline
  • 0638303: 8263497: Clean up sun.security.krb5.PrincipalName::toByteArray
  • ba22e6f: 8263446: Avoid unary minus over unsigned type in ObjectSynchronizer::dec_in_use_list_ceiling
  • b371f90: 8263504: Some OutputMachOpcodes fields are uninitialized
  • ... and 2 more: https://git.openjdk.java.net/jdk/compare/da9ead5e7fec1facdb4e44fc0a5b872edb704b9a...master

Your commit was automatically rebased without conflicts.

Pushed as commit d825198.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs hotspot hotspot-gc hotspot-runtime i18n integrated shenandoah
4 participants