Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8252825: Add automated test for fix done in JDK-8218479 #30

Closed
wants to merge 1 commit into from

Conversation

pankaj-bansal
Copy link

@pankaj-bansal pankaj-bansal commented Sep 6, 2020

Under JDK-8218479, fix was made to correct the rendering of JTextPane as the background color of JTextPane was similar to Panel color, so it looked like the JTextPane has transparent background. No automated test was written to verify the results. Current bug is to write the automated tests for the same.

The test fails without the fix done in JDK-8218479 and pass with the fix. I have run the tests multiple times in mach5. Links in JBS.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8252825: Add automated test for fix done in JDK-8218479

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/30/head:pull/30
$ git checkout pull/30

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 6, 2020

👋 Welcome back pbansal! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Sep 6, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 6, 2020

@pankaj-bansal The following label will be automatically applied to this pull request: swing.

When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label (add|remove) "label" command.

@openjdk openjdk bot added the swing label Sep 6, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 6, 2020

Webrevs

@pankaj-bansal
Copy link
Author

@pankaj-bansal pankaj-bansal commented Sep 6, 2020

/reviewer add @mrserb

@openjdk
Copy link

@openjdk openjdk bot commented Sep 6, 2020

@pankaj-bansal
Reviewer serb successfully added.

@openjdk
Copy link

@openjdk openjdk bot commented Sep 6, 2020

@pankaj-bansal This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

8252825: Add automated test for fix done in JDK-8218479

Reviewed-by: serb, prr
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there has been 1 commit pushed to the master branch:

  • 5f76deb: 8252522: nsk/share/test/StressOptions should multiple stressTime by jtreg's timeout-factor

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 5f76deb2e064ca8a48fb8a638c23aad34bf27f9c.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Sep 6, 2020
@pankaj-bansal
Copy link
Author

@pankaj-bansal pankaj-bansal commented Sep 6, 2020

/reviewer remove @mrserb

@openjdk
Copy link

@openjdk openjdk bot commented Sep 6, 2020

@pankaj-bansal
Reviewer serb successfully removed.

@openjdk openjdk bot removed the ready label Sep 6, 2020
mrserb
mrserb approved these changes Sep 6, 2020
@openjdk openjdk bot added the ready label Sep 6, 2020
prrace
prrace approved these changes Sep 6, 2020
@pankaj-bansal
Copy link
Author

@pankaj-bansal pankaj-bansal commented Sep 7, 2020

/integrate

@openjdk openjdk bot closed this Sep 7, 2020
@openjdk openjdk bot added integrated and removed ready labels Sep 7, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 7, 2020

@pankaj-bansal Since your change was applied there has been 1 commit pushed to the master branch:

  • 5f76deb: 8252522: nsk/share/test/StressOptions should multiple stressTime by jtreg's timeout-factor

Your commit was automatically rebased without conflicts.

Pushed as commit 55c7e76.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@openjdk openjdk bot removed the rfr label Sep 7, 2020
@pankaj-bansal pankaj-bansal deleted the JDK-8252825 branch Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated swing
3 participants