8253457: Remove unimplemented register stack functions #300
Conversation
|
👋 Welcome back coleenp! A progress list of the required criteria for merging this PR into |
|
@coleenp The following label will be automatically applied to this pull request: When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the |
Webrevs
|
There was a problem hiding this comment.
Looks good overall to me. I can see all these functions with no callers. Should they also be removed? I saw you removed only for thread_linux_arm.hpp.
./os_cpu/linux_aarch64/thread_linux_aarch64.hpp: void set_last_Java_fp(intptr_t* fp) { _anchor.set_last_Java_fp(fp); }
./os_cpu/linux_x86/thread_linux_x86.hpp: void set_last_Java_fp(intptr_t* fp) { _anchor.set_last_Java_fp(fp); }
./os_cpu/windows_x86/thread_windows_x86.hpp: void set_last_Java_fp(intptr_t* fp) { _anchor.set_last_Java_fp(fp); }
./os_cpu/linux_arm/thread_linux_arm.hpp: void set_last_Java_fp(intptr_t* fp) { _anchor.set_last_Java_fp(fp); }
./os_cpu/bsd_x86/thread_bsd_x86.hpp: void set_last_Java_fp(intptr_t* fp) { _anchor.set_last_Java_fp(fp); }
./cpu/aarch64/javaFrameAnchor_aarch64.hpp: void set_last_Java_fp(intptr_t* fp) { OrderAccess::release(); _last_Java_fp = fp; }
./cpu/arm/javaFrameAnchor_arm.hpp: void set_last_Java_fp(intptr_t* fp) { _last_Java_fp = fp; }
./cpu/x86/javaFrameAnchor_x86.hpp: void set_last_Java_fp(intptr_t* fp) { _last_Java_fp = fp; }
./share/runtime/javaFrameAnchor.hpp: void set_last_Java_pc(address pc) { _last_Java_pc = pc; }
./os_cpu/linux_arm/thread_linux_arm.hpp: void set_last_Java_pc(address pc) { _anchor.set_last_Java_pc(pc); }
I am not sure about last_Java_fp() as I didn't check thoroughly.
The other 5 removed function seem OK to me -- they don't do anything. The only exception is the *_zero.hpp versions that had some asserts, but I guess these asserts never caught anything since they don't exist on other ports anyway.
|
@coleenp This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements After integration, the commit message will be:
Since the source branch of this PR was last updated there have been 15 commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge ➡️ To integrate this PR with the above commit message to the |
|
/integrate |
|
/integrate |
openjdk
bot
added
integrated
|
@coleenp Since your change was applied there have been 15 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit b8ea80a. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Please review removed functions left over from Itanium.
Ran tier1 testing on Oracle platforms (linux-x64, macos-x64, windows-x64 and linux-aarch64) and built on linux-arm32,linux-ppc64le-debug,linux-s390x-debug,linux-x64-zero.
Thanks,
Coleen
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/300/head:pull/300$ git checkout pull/300